Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

[v16] bump ethereum-related dependencies #477

Merged
merged 10 commits into from
Apr 22, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 18, 2024

Description

Targeting v16.x.

Bump ethereumjs and metamask library packages to latest preserving compatibility with Nodejs v12.

  • Update eth-rpc-errors from ^3.0.0 to ^4.0.3
  • Update from eth-sig-util@^1.4.2 to @metamask/eth-sig-util@^4.0.1
    • The remaining usage of eth-sig-util@1 still present in lockfile comes from ganache-core, which is a devDependency only used for tests.
  • Update ethereumjs- packages
  • Update eth-json-rpc-filters from ^4.2.1 to ~5.0.0
    • 5.1.0 breaks node v12
  • Update from eth-json-rpc-infura@^5.1.0 to @metamask/eth-json-rpc-infura@^6.0.0
  • Fix resolution of ethereumjs-abi to fetch from package registry instead of github.com via git+http.
  • devDeps: Update from ganache-core to ganache-cli

Related

Copy link

socket-security bot commented Apr 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/cli@7.24.1 Transitive: environment, eval, filesystem, network, shell +18 1.52 MB nicolo-ribaudo
npm/@babel/code-frame@7.24.2 environment +4 114 kB nicolo-ribaudo
npm/@babel/compat-data@7.24.4 None 0 65.2 kB nicolo-ribaudo
npm/@babel/core@7.24.4 environment, filesystem, unsafe +14 2.77 MB nicolo-ribaudo
npm/@babel/generator@7.24.4 None +2 606 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6 None +3 94.2 kB nicolo-ribaudo
npm/@babel/helper-create-class-features-plugin@7.24.4 None +7 555 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.3 None 0 63.8 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.0 None 0 11.7 kB nicolo-ribaudo
npm/@babel/parser@7.24.4 None 0 1.88 MB nicolo-ribaudo
npm/@babel/preset-env@7.24.4 environment, filesystem Transitive: unsafe +99 4.12 MB nicolo-ribaudo
npm/@babel/template@7.24.0 None 0 68.9 kB nicolo-ribaudo
npm/@babel/types@7.24.0 environment +3 2.5 MB nicolo-ribaudo
npm/@cypress/request@3.0.1 environment, filesystem, network +33 2.2 MB cypress-npm-publisher
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None +1 224 kB jridgewell
npm/@ljharb/through@2.3.13 None 0 31.7 kB ljharb
npm/@metamask/eth-json-rpc-infura@6.0.0 None +2 97.6 kB gudahtt
npm/@metamask/eth-sig-util@4.0.1 Transitive: environment, filesystem +19 8.76 MB gudahtt
npm/browserslist@4.23.0 environment, filesystem Transitive: shell +3 93.7 kB ai
npm/call-bind@1.0.7 None +3 56.4 kB ljharb
npm/camelcase@5.3.1 None 0 7.45 kB sindresorhus
npm/cliui@5.0.0 None +2 60.7 kB bcoe
npm/decamelize@1.2.0 None 0 2.94 kB sindresorhus
npm/define-data-property@1.1.4 None +2 50.4 kB ljharb
npm/define-properties@1.2.1 None +1 39.4 kB ljharb
npm/es-abstract@1.23.3 None +40 3.22 MB ljharb
npm/es-errors@1.3.0 None 0 12.3 kB ljharb
npm/eth-json-rpc-filters@5.0.0 Transitive: environment, filesystem +29 8.89 MB gudahtt
npm/eth-json-rpc-middleware@8.1.0 network Transitive: environment, filesystem +21 8.76 MB gudahtt
npm/eth-rpc-errors@4.0.3 None 0 52.2 kB rekmarks
npm/execa@1.0.0 environment, shell Transitive: filesystem +6 49 kB sindresorhus
npm/fast-safe-stringify@2.1.1 None 0 39.7 kB matteo.collina
npm/find-up@3.0.0 Transitive: filesystem +5 28.8 kB sindresorhus
npm/function-bind@1.1.2 None 0 31.4 kB ljharb
npm/ganache-cli@6.12.2 environment, filesystem, shell, unsafe 0 22.7 MB truffle-cicd
npm/get-caller-file@2.0.5 None 0 4.72 kB stefanpenner
npm/get-intrinsic@1.2.4 eval 0 41.6 kB ljharb
npm/has-property-descriptors@1.0.2 None +1 22.7 kB ljharb
npm/has-proto@1.0.3 None 0 12 kB ljharb
npm/has-tostringtag@1.0.2 None 0 17.6 kB ljharb
npm/has@1.0.4 None 0 3.02 kB tarruda
npm/hasown@2.0.2 None 0 8.77 kB ljharb
npm/invert-kv@2.0.0 None 0 2.38 kB sindresorhus
npm/is-shared-array-buffer@1.0.3 None 0 18.7 kB ljharb
npm/json-stable-stringify@1.1.1 None +2 57.7 kB ljharb
npm/jsonify@0.0.1 None 0 19.4 kB ljharb
npm/lcid@2.0.0 None 0 6.37 kB sindresorhus
npm/map-age-cleaner@0.1.3 None +1 11.3 kB samverschueren
npm/mem@4.3.0 None +1 13.3 kB sindresorhus
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/node-fetch@2.7.0 network +3 493 kB node-fetch-bot
npm/node-releases@2.0.14 None 0 34 kB chicoxyzzy
npm/os-locale@3.1.0 environment 0 6.18 kB sindresorhus
npm/parse-asn1@5.1.7 Transitive: unsafe +2 77.4 kB ljharb
npm/readable-stream@2.3.8 environment +5 147 kB matteo.collina
npm/regexp.prototype.flags@1.5.2 None +2 73.8 kB ljharb
npm/require-directory@2.1.1 filesystem 0 12.1 kB troygoode
npm/require-main-filename@2.0.0 None 0 3.93 kB bcoe
npm/set-blocking@2.0.0 None 0 4.22 kB bcoe
npm/side-channel@1.0.6 None +1 120 kB ljharb
npm/signal-exit@3.0.7 None 0 9.96 kB isaacs
npm/string.prototype.trim@1.2.9 None +1 42.7 kB ljharb
npm/tape@4.17.0 environment, filesystem +12 670 kB ljharb
npm/which-module@2.0.1 None 0 4.04 kB nexdrew
npm/which-typed-array@1.1.15 None +3 79.7 kB ljharb
npm/y18n@4.0.3 filesystem 0 11 kB oss-bot
npm/yargs-parser@13.1.2 environment 0 57.1 kB oss-bot
npm/yargs@13.2.4 environment, filesystem 0 228 kB bcoe

🚮 Removed packages: npm/@babel/cli@7.23.0, npm/@babel/code-frame@7.22.13, npm/@babel/compat-data@7.23.2, npm/@babel/core@7.23.0, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-create-class-features-plugin@7.22.15, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-module-transforms@7.23.0, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/helper-replace-supers@7.22.20, npm/@babel/parser@7.23.0, npm/@babel/plugin-transform-optional-chaining@7.23.0, npm/@babel/preset-env@7.23.2, npm/@babel/template@7.22.15, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@cypress/request@3.0.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/constants@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/properties@5.7.0, npm/@ethersproject/strings@5.7.0, npm/@ethersproject/transactions@5.7.0, npm/@jridgewell/trace-mapping@0.3.19, npm/@types/cacheable-request@6.0.3, npm/accepts@1.3.8, npm/ansi-regex@5.0.0, npm/array.prototype.reduce@1.0.5, npm/bignumber.js@9.1.1, npm/body-parser@1.20.1, npm/browserslist@4.22.1, npm/bufferutil@4.0.7, npm/cacheable-lookup@5.0.4, npm/content-disposition@0.5.4, npm/cookie@0.5.0, npm/cookiejar@2.1.4, npm/core-js-pure@3.26.1, npm/cross-fetch@2.2.6, npm/decode-uri-component@0.2.2, npm/define-properties@1.1.4, npm/duplexer3@0.1.5, npm/es-abstract@1.20.5, npm/es5-ext@0.10.62, npm/eth-json-rpc-filters@4.2.1, npm/ethereum-bloom-filters@1.0.10, npm/ethereumjs-block@1.7.1, npm/express@4.18.2, npm/fast-safe-stringify@2.0.7, npm/ganache-core@2.13.2, npm/get-intrinsic@1.1.3, npm/graceful-fs@4.2.10, npm/http2-wrapper@1.0.3, npm/json-rpc-engine@5.3.0, npm/json-stable-stringify@1.0.1, npm/keccak@3.0.1, npm/minimist@1.2.7, npm/mock-fs@4.14.0, npm/node-fetch@2.6.7, npm/node-gyp-build@4.5.0, npm/normalize-url@4.5.1, npm/object-inspect@1.12.2, npm/object.getownpropertydescriptors@2.1.5, npm/pull-stream@3.7.0, npm/readable-stream@2.3.7, npm/regexp.prototype.flags@1.4.3, npm/sshpk@1.17.0, npm/swarm-js@0.1.42, npm/tape@4.16.1, npm/utf-8-validate@5.0.10, npm/websocket@1.0.34

View full report↗︎

Copy link

socket-security bot commented Apr 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/browser-resolve@2.0.0, npm/eth-json-rpc-middleware@8.1.0, npm/execa@1.0.0, npm/ganache-cli@6.12.2, npm/hash-base@3.0.4, npm/jsonify@0.0.1, npm/parse-asn1@5.1.7, npm/v8-compile-cache@2.4.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/eth-json-rpc-middleware@8.1.0

network access ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/@ethersproject/providers@5.7.2
@SocketSecurity ignore npm/micro-ftch@0.3.1

network access ok

@legobeat legobeat marked this pull request as ready for review April 18, 2024 05:31
@legobeat legobeat requested a review from a team as a code owner April 18, 2024 05:31
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/jsonify@0.0.1
@SocketSecurity ignore npm/browser-resolve@2.0.0
@SocketSecurity ignore npm/hash-base@3.0.4

new author ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/v8-compile-cache@2.4.0

new author ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/parse-asn1@5.1.7

new author ok

@legobeat
Copy link
Contributor Author

legobeat commented Apr 18, 2024

@SocketSecurity ignore npm/execa@1.0.0
@SocketSecurity ignore npm/ganache-cli@6.12.2

ganache update ok

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 277e195 into MetaMask:v16.x Apr 22, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants