Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) move graphql into peerDependecies #148

Closed
wants to merge 1 commit into from

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Sep 9, 2018

fixes #144

@capaj
Copy link
Contributor Author

capaj commented Sep 9, 2018

sorry about all the code style changes in changelog and readme but this is how prettier formats it and you have prettier enabled here, so I though it won't do any damage to have it formatted correctly.

@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files          60       60           
  Lines         958      958           
  Branches      170      170           
=======================================
  Hits          911      911           
  Misses         46       46           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f5278...498bc7f. Read the comment docs.

@MichalLytek
Copy link
Owner

I've decided to not migrate to peerDependency for now.
Closing this PR as it's overtaken by #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use GraphQLSchema from another module or realm
2 participants