Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved @types/graphql from dependencies to dev-dependencies #179

Closed

Conversation

mechanical-turk
Copy link

image

As described in the FAQ page, multiple versions of @types/graphql causes build issues as the compiler gets confused. This is an attempt at decreasing the probability of having multiple versions of the package by moving @types/graphql to dev-dependencies.

@mechanical-turk
Copy link
Author

Tests passing:

image

@MichalLytek
Copy link
Owner

MichalLytek commented Oct 22, 2018

Unfortunately, we can't do that. It would cause that without manual installing of @types/graphql your app won't even compile, return type from buildSchema will be any, etc.

We could only move it do peerDependency and it would have to be done together with main graphql dependency but that was rejected a few weeks ago - see #148 and #144.

@MichalLytek MichalLytek added Wontfix ❌ This will not be worked on Community 👨‍👧 Something initiated by a community labels Oct 22, 2018
@mechanical-turk mechanical-turk deleted the build-error-fix branch October 22, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants