Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search viewlet searching opened files regardless or include and exclude patterns #31819

Closed
Tyriar opened this issue Aug 1, 2017 · 20 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2017

  • VSCode Version: Code - Insiders 1.15.0-insider (f39385b, 2017-08-01T05:16:44.254Z)
  • OS Version: Windows_NT x64 10.0.14393
  • Extensions:
Extension Author (truncated) Version
git-project-manager fel 1.3.2
seti-icons qin 0.1.3

(1 theme extensions excluded)


Testing #31480

Searching https://github.com/sourcelair/xterm.js, notice that dist is excluded in settings, I have an explicit include setting, but because dist/xterm.js is opened (not active) search results are still presented.

image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Aug 1, 2017
@vscodebot vscodebot bot added the insiders label Aug 1, 2017
@roblourens
Copy link
Member

I did miss a case

@Tyriar
Copy link
Member Author

Tyriar commented Aug 1, 2017

This is also causing the results to look particularly confusing when there actually are results:

image

Notice that the other results are in ./src but it's not shown next to the files because there's an assumption that only 1 folder is showing.

@roblourens roblourens added this to the July 2017 milestone Aug 1, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 4, 2017

I'm still seeing results from non-active opened files returned even though they are excluded by search.exclude:

screen shot 2017-08-04 at 11 53 01 am

@roblourens Are these the correct test steps?

@jednano
Copy link

jednano commented Jan 22, 2018

Any way to promote this ticket out of the backlog? It's extremely annoying.

@jpike88
Copy link

jpike88 commented Jan 25, 2018

This is driving me insane! It renders search almost unusable... this should be a priority bug fix!

screen shot 2018-01-25 at 4 20 24 pm

@alvipeo
Copy link

alvipeo commented Mar 14, 2018

Guys, can you please fix this? It searches within node_modules in my angular app even if I exclude it!!! You can imagine what a mess it shows as a result!

@xsburg
Copy link

xsburg commented Mar 26, 2018

For those who come across this thread like I did.
Double check that the cog icon is enabled like in the picture below. When disabled, the search mechanism disregards the settings and goes over all directories. Solved the problem for me.

@akbyrd
Copy link
Contributor

akbyrd commented Apr 8, 2020

This is super frustrating.

@tudor07
Copy link

tudor07 commented Nov 13, 2020

**/distdid not work for me but dist/** did

@tokomeno
Copy link

3 years past after the issue has been opened and still not fixed :(

Frustrating

@sujithmathewthomas
Copy link

Any luck on this?

@gigitux
Copy link

gigitux commented Jun 23, 2021

Same problem here

@braddialpad
Copy link

Man I just spent over an hour trying to figure out why my package-lock.json kept getting included in search when I had it specifically excluded in settings. Then I found this bug.. yeah I had it open.

@julee
Copy link

julee commented Mar 24, 2022

Five years past. Any help can I provide to resolve this issue. It's troublesome.

@glasser
Copy link

glasser commented Mar 31, 2022

I don't suppose anyone has found a workaround? eg, I'd use an extension with a "close editors associated with search.excluded files" command...

@abyrd-phx
Copy link

There's a related but different feature request to ignore opened editors entirely here #153747 if folks following this thread are looking for that behavior as well.

@dizys
Copy link

dizys commented Jul 22, 2022

How is this still an issue?!? 😫

@andreamah andreamah assigned andreamah and unassigned roblourens Dec 15, 2022
@andreamah
Copy link
Contributor

I believe this is fixed.
image

Notice that the results from notebook.css are not appearing in the search results.

@andreamah andreamah modified the milestones: Backlog, December 2023 Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@anthonykim1 anthonykim1 added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests