Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-microsoft-visualstudio-testtools-unittesting-members-in-… #8920

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

engyebrahim
Copy link
Contributor

related to: microsoft/testfx#1574

@prmerger-automator
Copy link
Contributor

@engyebrahim : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ae92fd8:

✅ Validation status: passed

File Status Preview URL Details
docs/test/using-microsoft-visualstudio-testtools-unittesting-members-in-unit-tests.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Feb 3, 2023

@Mikejo5000

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Feb 3, 2023
@@ -239,7 +239,7 @@ public class MyOtherTestClass

It's possible to control the inheritance behavior: only for current class using `InheritanceBehavior.None` or for all derived classes using `InheritanceBehavior.BeforeEachDerivedClass`.

It's also possible to configure whether the class cleanup should be run at the end of the class or at the end of the assembly (current default).
It's also possible to configure whether the class cleanup should be run at the end of the class or at the end of the assembly (No longer supported starting from MSTest v4 as EndOfClass is the default and only ClassCleanup behavior).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other PR. Can we make "ClassCleanup" a link? I don't think it's mentioned elsewhere in this doc, so might be confusing.

…embers-in-unit-tests.md

Co-authored-by: Mike Jones <mikejo@microsoft.com>
@prmerger-automator
Copy link
Contributor

@engyebrahim : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 2b0332f:

✅ Validation status: passed

File Status Preview URL Details
docs/test/using-microsoft-visualstudio-testtools-unittesting-members-in-unit-tests.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@engyebrahim : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 32fbfa4:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/test/using-microsoft-visualstudio-testtools-unittesting-members-in-unit-tests.md ⚠️Warning Details

docs/test/using-microsoft-visualstudio-testtools-unittesting-members-in-unit-tests.md

  • Line 242, Column 210: [Warning: file-not-found - See documentation] Invalid file link: 'Microsoft.VisualStudio.TestTools.UnitTesting.ClassCleanupAttribute'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@engyebrahim : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5924db4:

✅ Validation status: passed

File Status Preview URL Details
docs/test/using-microsoft-visualstudio-testtools-unittesting-members-in-unit-tests.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Evangelink
Copy link
Contributor

@Mikejo5000 MSTest v4 is not yet available so maybe you want to keep this PR on-hold for now. We will ping you once v4 is released.

Note that if that's fine for you, I don't mind merging it now.

@Mikejo5000
Copy link
Collaborator

@Evangelink Is there a planned release date?

@Evangelink
Copy link
Contributor

@Mikejo5000 Not at the moment. We are discussing planning so I hope to be able to give you more info soon.

@Mikejo5000
Copy link
Collaborator

@Evangelink Any updates on the release date? These are small changes, and seem OK to merge if you're sure these changes will be part of v4, when it comes.

@engyebrahim
Copy link
Contributor Author

Hi @Mikejo5000 we don't know yet the release date, but yeah we are sure it'll be part of v4 so you can merge it. Thanks!!

@Mikejo5000
Copy link
Collaborator

#sign-off

@prmerger-automator
Copy link
Contributor

@engyebrahim : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Mar 14, 2023

@engyebrahim @Mikejo5000 - without staging, we can't test the xref: link - which looks okay but you should verify that it works after publish. thanks.

@Jak-MS Jak-MS merged commit 0c76238 into MicrosoftDocs:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants