Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ClassCleanupBehavior.EndOfAssembly #1574

Closed
Evangelink opened this issue Feb 2, 2023 · 0 comments · Fixed by #1570
Closed

Remove ClassCleanupBehavior.EndOfAssembly #1574

Evangelink opened this issue Feb 2, 2023 · 0 comments · Fixed by #1570
Assignees
@engyebrahim
Labels
Breaking ‼️ State: In-PR Type: Feature

Comments

@Evangelink
Copy link
Member

Evangelink commented Feb 2, 2023 •
edited by testplatform-bot
Loading

Summary

The initial idea was to deprecate ClassCleanupBehavior.EndOfAssembly and remove it in a later release (see #1541) but given that we already did the breaking change of replacing default from EndOfAssembly to EndOfClass (see #1316), it seems that people who would be broken would already have to do fix their tests so we could directly guide them toward using AssemblyCleanup.

AB#1736146
This was referenced Feb 2, 2023
Merged
Open
@engyebrahim engyebrahim mentioned this issue Feb 3, 2023
Merged
Evangelink pushed a commit that referenced this issue Feb 3, 2023
@engyebrahim
Remove ClassCleanupBehavior.EndOfAssembly (#1570)
6ededf0 
Fixes #1574
@engyebrahim engyebrahim mentioned this issue Feb 3, 2023
Merged
@pavelhorak pavelhorak removed the sprint label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engyebrahim engyebrahim

Labels
Breaking ‼️ State: In-PR Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ClassCleanupBehavior.EndOfAssembly engyebrahim/testfx
3 participants
@Evangelink @pavelhorak @engyebrahim