Rename MobileIdClient Configuration Parameters

[phaupt]

Please rename some of the configuration parameters as described below. This should help to better understand the purpose of the variable.

Current configuration example:

  <mobileIdClient
    AP_ID = "mid://adfs-dev.swisscom.ch"
    SslKeystore = "LocalMachine"
    SslCertThumbprint = "19cb073f974729d9fec8cb1a0c50866886fcdeba"
    SslRootCaCertDN = "C=CH, O=Swisscom, OID.2.5.4.97=VATCH-CHE-101.654.423, OU=Digital Certificate Services, CN=Swisscom Root CA 4"
    SslRootCaCertFiles = "C:\Program Files (x86)\MobileIdAdfs\v1.3\certs\Swisscom_Root_CA_2.crt;C:\Program Files (x86)\MobileIdAdfs\v1.3\certs\Swisscom_Root_CA_4.crt" 
    SignatureProfile = http://mid.swisscom.ch/Any-LoA4
    DtbsPrefix = "ADFS Demo: "
    RequestTimeOutSeconds = "60"
    PollResponseIntervalSeconds = "1"
    PollResponseDelaySeconds = "3"
    ServiceUrlPrefix  = https://mobileid.swisscom.com/soap/services/
    SecurityProtocolType = "Tls12"
    EnableSubscriberInfo = "false"
    DisableSignatureValidation = "false"
    DisableSignatureCertValidation = "false"
  />

1. sslRootCaCertDN
   According to the src code, this DN is loaded when the SSL connection is established to mobileid.swisscom.com , which is illogical and makes no sense. Please adjust the code so that we can remove this variable from the configuration completely.
2. SslKeystore
   Rename to SslMidClientKeystore. This should make it clearer that this is only about the MobileID AP client certificate and not about server or SignResp certificates.
3. SslCertThumbprint
   Rename to SslMidClientCertThumbprint. This should make it clearer that this is only about the MobileID AP client certificate and not about server or SignResp certificates.
4. SslRootCaCertFiles
   Rename to SignRespCertFiles. This makes confusion with the server certificate (mobileid.swisscom.com) less likely.
5. DisableSignatureValidation
   Rename to DisableSignRespValidation. This makes confusion with the server certificate (mobileid.swisscom.com) less likely.
6. DisableSignatureCertValidation
   Rename to DisableSignRespCertValidation. This makes confusion with the server certificate (mobileid.swisscom.com) less likely.

The new configuration should then look like this:

  <mobileIdClient
    AP_ID = "mid://adfs-dev.swisscom.ch"
    SslMidClientKeystore = "LocalMachine"
    SslMidClientCertThumbprint = "19cb073f974729d9fec8cb1a0c50866886fcdeba"
    SignRespCertFiles = "C:\Program Files (x86)\MobileIdAdfs\v1.3\certs\Swisscom_Root_CA_2.crt;C:\Program Files (x86)\MobileIdAdfs\v1.3\certs\Swisscom_Root_CA_4.crt" 
    SignatureProfile = http://mid.swisscom.ch/Any-LoA4
    DtbsPrefix = "ADFS Demo: "
    RequestTimeOutSeconds = "60"
    PollResponseIntervalSeconds = "1"
    PollResponseDelaySeconds = "3"
    ServiceUrlPrefix  = https://mobileid.swisscom.com/soap/services/
    SecurityProtocolType = "Tls12"
    EnableSubscriberInfo = "false"
    DisableSignRespValidation = "false"
    DisableSignRespCertValidation = "false"
  />