Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: feed_info should include start_date, end_date, version, email, url #1156

Merged
merged 8 commits into from
Jun 29, 2022
Merged

feat: feed_info should include start_date, end_date, version, email, url #1156

merged 8 commits into from
Jun 29, 2022

Conversation

KClough
Copy link
Collaborator

@KClough KClough commented May 18, 2022 •
edited
Loading

Summary:

Related #885

Expected behavior:

Applies the best practice for feed_info.txt to includes valid fields for:

  • feed_start_date, feed_end_date
  • Feed_version.
  • Feed_email
  • feed_url

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
    - [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@KClough KClough mentioned this pull request May 18, 2022
Merged
3 tasks
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 75557c0 here (report will disappear after 90 days).

@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch from d91d5b0 to d0e192c Compare May 20, 2022 04:13
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch from d0e192c to 44ef231 Compare June 24, 2022 01:52
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

1 similar comment
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch 2 times, most recently from 2c39db4 to f416d65 Compare June 24, 2022 02:08
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

1 similar comment
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch from f416d65 to c006cfa Compare June 24, 2022 02:10
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

Due to changes in this pull request, the following validation rules trigger new errors:

Download the full acceptance test report for commit 616a5e3 here (report will disappear after 90 days).

@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit c522547 here (report will disappear after 90 days).

maximearmstrong
maximearmstrong approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KClough! We can merge this one after #1157 is.

@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch 2 times, most recently from 4c344d4 to bbd679b Compare June 29, 2022 20:57
@KClough KClough marked this pull request as draft June 29, 2022 20:58
@KClough KClough force-pushed the feat/apply-recommended-field-annotation-to-feed-info branch from bbd679b to b7f72db Compare June 29, 2022 21:04
@KClough KClough marked this pull request as ready for review June 29, 2022 21:05
maximearmstrong
maximearmstrong suggested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing aside, we should be able to merge! The validator cannot be compiled right now because one @Recommended annotation is duplicated.

main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedInfoSchema.java Outdated Show resolved Hide resolved
@KClough @maximearmstrong
Update main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFe…
6925d4a 
…edInfoSchema.java

Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 3b66a00 here (report will disappear after 90 days).

maximearmstrong
maximearmstrong approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @KClough

@maximearmstrong maximearmstrong merged commit 60a6503 into master Jun 29, 2022
@maximearmstrong maximearmstrong deleted the feat/apply-recommended-field-annotation-to-feed-info branch June 29, 2022 22:18
@isabelle-dr isabelle-dr mentioned this pull request Jan 23, 2023
Closed
@takohei takohei mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximearmstrong maximearmstrong maximearmstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KClough @maximearmstrong