Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add point near pole #1211

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Docs: Add point near pole #1211

merged 1 commit into from
Jul 19, 2022

Conversation

isabelle-dr
Copy link
Contributor

@isabelle-dr isabelle-dr commented Jul 19, 2022 •
edited
Loading

Closes #1210.

Summary:

This PR adds the missing notice in RULES.md.

Expected behavior:

The notice information appears in RULES.md and is accurate.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Screen Shot 2022-07-19 at 7 53 22 AM

@isabelle-dr isabelle-dr mentioned this pull request Jul 19, 2022
Closed
maximearmstrong
maximearmstrong approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @isabelle-dr

@maximearmstrong maximearmstrong merged commit b4474a9 into master Jul 19, 2022
@maximearmstrong maximearmstrong deleted the add-point-near-origin branch July 19, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximearmstrong maximearmstrong maximearmstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

point_near_pole notice is missing from RULES.md
2 participants
@isabelle-dr @maximearmstrong