Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toggle Expanders] doesn't work with Show/Hide resolved #100

Closed
aspiers opened this issue Aug 29, 2019 · 5 comments
Closed

[Toggle Expanders] doesn't work with Show/Hide resolved #100

aspiers opened this issue Aug 29, 2019 · 5 comments
Labels
bug

Comments

@aspiers
Copy link

aspiers commented Aug 29, 2019

I was pretty sure that Shift+click and Control+Shift+click on Show/Hide resolved expanders in PRs used to work, but it certainly doesn't work for me now - it just behaves like a normal click without Shift or Control. Here's an example I used to test: crowbar/crowbar-core#1853
@Mottie
Copy link
Owner

Mottie commented Aug 30, 2019

Hi @aspiers!

Thanks, I'll take a look this weekend.

@Mottie
Copy link
Owner

Mottie commented Sep 2, 2019

Hmm, did they get rid of the outdated toggle? I think it was renamed to show/hide resolved and outdated was moved to a label inside the block.

@aspiers
Copy link
Author

aspiers commented Sep 2, 2019

Yes that's right I think.

Mottie added a commit that referenced this issue Sep 2, 2019
@Mottie
Toggle-expanders: Update to use new GitHub class names:
288ea49 
* Changed commit, release & pull request behavior:
  * Using Shift + Click on an expander only toggles the other
    expanders within a date block.
  * Using (Ctrl or ⌘) + Shift + Click on an expander
    now toggles all expanders.
* Fixes issues #100, #101 & #87.
@Mottie Mottie added the bug label Sep 2, 2019
@Mottie
Copy link
Owner

Mottie commented Sep 2, 2019

Please try out the latest version.

@Mottie Mottie closed this as completed Sep 2, 2019
@aspiers
Copy link
Author

aspiers commented Sep 3, 2019

Works perfectly now, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aspiers @Mottie