Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleExpanders] Shift+click not working when comparing branches/tags #87

Closed
malnvenshorn opened this issue Jun 11, 2019 · 1 comment
Closed

[ToggleExpanders] Shift+click not working when comparing branches/tags #87

malnvenshorn opened this issue Jun 11, 2019 · 1 comment
Labels
enhancement

Comments

@malnvenshorn
Copy link

malnvenshorn commented Jun 11, 2019 •
edited
Loading

At the moment toggling only toggling with ctrl+shift+click is working when comparing branches/tags, e.g. torvalds/linux@v5.2-rc1...v5.2-rc2

Consider this change to enable shift+click within that view

const parentNode = stateNode.closest(modKey ?
	".container, .js-discussion" :
	".commit-group, .js-timeline-item, .timeline-commits"
);

It would also be great to be able to toggle file diffs.
@Mottie
Copy link
Owner

Mottie commented Jun 13, 2019

Hi @malnvenshorn!

That sounds reasonable, I'll look into it!

@Mottie Mottie closed this as completed in 01b1ef2 Jun 13, 2019
Mottie added a commit that referenced this issue Sep 2, 2019
@Mottie
Toggle-expanders: Update to use new GitHub class names:
288ea49 
* Changed commit, release & pull request behavior:
  * Using Shift + Click on an expander only toggles the other
    expanders within a date block.
  * Using (Ctrl or ⌘) + Shift + Click on an expander
    now toggles all expanders.
* Fixes issues #100, #101 & #87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mottie @malnvenshorn