-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): clean up gradle deprecations #46
Conversation
# Conflicts: # cr-core/build.gradle
id "eclipse" | ||
id "idea" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know those are just here because they were present before - but do we still need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eclipse: no idea. it does seem like it's been years since any of us have tried to support an eclipse workspace.
idea: given we don't have any idea { }
customizations in this file, maybe not? haven't checked.
// Using the parent's path here to allow the CR to be embedded deeper in a Terasology workspace | ||
String crCorePath = parent.path + ":cr-core" | ||
// If we're in a standalone workspace we'll end up with "::cr-core" so fix real quick | ||
crCorePath = crCorePath.replaceAll('::', ':') | ||
println "cr-destsol is setting its cr-core dependency using path " + crCorePath | ||
compile project(crCorePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was trying to do path-manipulation hijinks so it could work like an included build does, before included builds were an official gradle feature.
These are mostly straightforward replacements for new names or syntax.
One thing that has more of an impact is replacing the
compile
dependencies. The right answer is usuallyimplementation
.Terasology compiles with this after MovingBlocks/Terasology#4845, and I successfully uploaded a log with it.