chore(build): clean up gradle deprecations #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cr-core/build.gradle
skaldarnar
approved these changes
Aug 26, 2021
Comment on lines
+8
to
+9
| id "eclipse" | ||
| id "idea" |
There was a problem hiding this comment.
I know those are just here because they were present before - but do we still need them?
There was a problem hiding this comment.
eclipse: no idea. it does seem like it's been years since any of us have tried to support an eclipse workspace.
idea: given we don't have any idea { } customizations in this file, maybe not? haven't checked.
Comment on lines
-10
to
-15
| // Using the parent's path here to allow the CR to be embedded deeper in a Terasology workspace | ||
| String crCorePath = parent.path + ":cr-core" | ||
| // If we're in a standalone workspace we'll end up with "::cr-core" so fix real quick | ||
| crCorePath = crCorePath.replaceAll('::', ':') | ||
| println "cr-destsol is setting its cr-core dependency using path " + crCorePath | ||
| compile project(crCorePath) |
There was a problem hiding this comment.
Is this just no longer necessary?
There was a problem hiding this comment.
I think it was trying to do path-manipulation hijinks so it could work like an included build does, before included builds were an official gradle feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly straightforward replacements for new names or syntax.
One thing that has more of an impact is replacing the
compiledependencies. The right answer is usuallyimplementation.Terasology compiles with this after MovingBlocks/Terasology#4845, and I successfully uploaded a log with it.