-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): clean up gradle deprecations #46
Changes from all commits
e607083
aba2c91
57243a9
4c549e2
130a75c
67fb274
d269973
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,15 @@ | ||
// Copyright 2021 The Terasology Foundation | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
apply plugin: 'java' | ||
apply plugin: 'maven' | ||
apply plugin: 'eclipse' | ||
apply plugin: 'idea' | ||
plugins { | ||
id "java-library" | ||
id "maven-publish" | ||
id "eclipse" | ||
id "idea" | ||
} | ||
|
||
dependencies { | ||
// Using the parent's path here to allow the CR to be embedded deeper in a Terasology workspace | ||
String crCorePath = parent.path + ":cr-core" | ||
// If we're in a standalone workspace we'll end up with "::cr-core" so fix real quick | ||
crCorePath = crCorePath.replaceAll('::', ':') | ||
println "cr-destsol is setting its cr-core dependency using path " + crCorePath | ||
compile project(crCorePath) | ||
Comment on lines
-10
to
-15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this just no longer necessary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it was trying to do path-manipulation hijinks so it could work like an included build does, before included builds were an official gradle feature. |
||
api project(":cr-core") | ||
} | ||
|
||
apply from: "$rootDir/gradle/common.gradle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know those are just here because they were present before - but do we still need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eclipse: no idea. it does seem like it's been years since any of us have tried to support an eclipse workspace.
idea: given we don't have any
idea { }
customizations in this file, maybe not? haven't checked.