[XY] Remove vis type xy renderer (elastic#138735)

* Remove vis type xy renderer * Fix check * Remove unused translations * Some * Updated limits * Update limits Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Mpdreamz · Sep 6, 2022 · 564ea41 · 564ea41
1 parent 0634fa8
commit 564ea41
Show file tree

Hide file tree

Showing 73 changed files with 28 additions and 6,417 deletions.
diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml
@@ -70,7 +70,7 @@ pageLoadAssetSize:
   visTypeTimeseries: 55203
   visTypeVega: 153573
   visTypeVislib: 242838
-  visTypeXy: 113478
+  visTypeXy: 30000
   visualizations: 90000
   watcher: 43598
   runtimeFields: 41752

diff --git a/src/plugins/charts/public/index.ts b/src/plugins/charts/public/index.ts
@@ -9,6 +9,7 @@
 // TODO: https://github.com/elastic/kibana/issues/110891
 /* eslint-disable @kbn/eslint/no_export_all */
 
+import { RangeSelectContext, ValueClickContext } from '@kbn/embeddable-plugin/public';
 import { ChartsPlugin } from './plugin';
 
 export const plugin = () => new ChartsPlugin();
@@ -19,6 +20,16 @@ export * from './static';
 export { lightenColor } from './services/palettes/lighten_color';
 export { useActiveCursor } from './services/active_cursor';
 
+export interface ClickTriggerEvent {
+  name: 'filter';
+  data: ValueClickContext['data'];
+}
+
+export interface BrushTriggerEvent {
+  name: 'brush';
+  data: RangeSelectContext['data'];
+}
+
 export type {
   CustomPaletteArguments,
   CustomPaletteState,

diff --git a/src/plugins/charts/public/static/index.ts b/src/plugins/charts/public/static/index.ts
@@ -8,5 +8,4 @@
 
 export * from './colors';
 export * from './components';
-export * from './utils';
 export * from '../../common/static/styles';
diff --git a/src/plugins/charts/public/static/utils/index.ts b/src/plugins/charts/public/static/utils/index.ts
diff --git a/src/plugins/charts/public/static/utils/transform_click_event.ts b/src/plugins/charts/public/static/utils/transform_click_event.ts
diff --git a/src/plugins/vis_types/vislib/kibana.json b/src/plugins/vis_types/vislib/kibana.json
@@ -5,7 +5,7 @@
   "ui": true,
   "requiredPlugins": ["charts", "data", "expressions", "visualizations", "fieldFormats"],
   "optionalPlugins": ["usageCollection"],
-  "requiredBundles": ["kibanaUtils", "visTypeXy", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"],
+  "requiredBundles": ["kibanaUtils", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"],
   "owner": {
     "name": "Vis Editors",
     "githubTeam": "kibana-vis-editors"

diff --git a/src/plugins/vis_types/vislib/public/vislib/helpers/point_series/_add_to_siri.ts b/src/plugins/vis_types/vislib/public/vislib/helpers/point_series/_add_to_siri.ts
@@ -6,11 +6,12 @@
  * Side Public License, v 1.
  */
 
-import { getAggId } from '@kbn/vis-type-xy-plugin/public';
 import type { Dimension } from '@kbn/vis-type-xy-plugin/public';
 
 import { Point } from './_get_point';
 
+const getAggId = (accessor: string) => (accessor ?? '').split('-').pop() ?? '';
+
 export interface Serie {
   id: string;
   rawId: string;

diff --git a/src/plugins/vis_types/xy/common/index.ts b/src/plugins/vis_types/xy/common/index.ts
@@ -14,8 +14,3 @@ export enum ChartType {
   Area = 'area',
   Histogram = 'histogram',
 }
-
-/**
- * Type of xy visualizations
- */
-export type XyVisType = ChartType | 'horizontal_bar';
diff --git a/src/plugins/vis_types/xy/kibana.json b/src/plugins/vis_types/xy/kibana.json
@@ -3,9 +3,8 @@
   "version": "kibana",
   "ui": true,
   "server": true,
-  "requiredPlugins": ["charts", "data", "expressions", "visualizations", "fieldFormats"],
-  "requiredBundles": ["kibanaUtils", "visDefaultEditor", "kibanaReact"],
-  "optionalPlugins": ["usageCollection"],
+  "requiredPlugins": ["charts", "visualizations", "data", "expressions"],
+  "requiredBundles": ["kibanaUtils", "visDefaultEditor"],
   "extraPublicDirs": ["common/index"],
   "owner": {
     "name": "Vis Editors",

diff --git a/src/plugins/vis_types/xy/public/_chart.scss b/src/plugins/vis_types/xy/public/_chart.scss