Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] Remove vis type xy renderer #138735

Merged
merged 9 commits into from
Aug 18, 2022
Merged

[XY] Remove vis type xy renderer #138735

merged 9 commits into from
Aug 18, 2022

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Aug 12, 2022 •
edited
Loading

Part of #127115

Summary

As now we are using unified expression renderer (#136475) we should remove the old one from vis type xy plugin.

@VladLasitsa VladLasitsa requested a review from flash1293 August 12, 2022 13:56
@VladLasitsa VladLasitsa self-assigned this Aug 12, 2022
@VladLasitsa VladLasitsa added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.5.0 labels Aug 12, 2022
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa VladLasitsa marked this pull request as ready for review August 16, 2022 08:52
@VladLasitsa VladLasitsa requested review from a team as code owners August 16, 2022 08:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa mentioned this pull request Aug 16, 2022
Closed
31 tasks
@flash1293
Copy link
Contributor

This mostly LGTM, thanks!

Two other small things:

  • src/plugins/charts/public/static/utils/transform_click_event.ts doesn't seem to be used anymore
  • Adjust limits for visTypeXy so it doesn't grow again

@VladLasitsa
Merge remote-tracking branch 'upstream/main' into remove_vis_type_xy_…
a4b3b65 
…renderer

# Conflicts:
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@VladLasitsa
Some
9ddc1a6
@VladLasitsa
Copy link
Contributor Author

This mostly LGTM, thanks!

Two other small things:

  • src/plugins/charts/public/static/utils/transform_click_event.ts doesn't seem to be used anymore
  • Adjust limits for visTypeXy so it doesn't grow again

Done

flash1293
flash1293 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green

mbondyra
mbondyra approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR, so many lines out. Didn't test, just went through the code - I think CI is enough 🆗

@VladLasitsa VladLasitsa requested a review from a team as a code owner August 17, 2022 15:31
jbudz
jbudz approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 91 89 -2
visTypeXy 93 43 -50
total -52

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 253 246 -7
visTypeXy 51 50 -1
total -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 348.8KB 348.8KB -1.0B
visTypeXy 60.2KB 33.0KB -27.2KB
total -27.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 46.3KB 44.4KB -1.9KB
visTypeVislib 15.6KB 15.5KB -99.0B
visTypeXy 47.1KB 27.6KB -19.4KB
total -21.4KB
Unknown metric groups

API count

id before after diff
charts 272 261 -11
visTypeXy 57 53 -4
total -15

async chunk count

id before after diff
visTypeXy 3 2 -1

ESLint disabled line counts

id before after diff
visTypeXy 5 4 -1

References to deprecated APIs

id before after diff
visTypeXy 5 0 -5

Total ESLint disabled count

id before after diff
visTypeXy 6 5 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit bb705c8 into elastic:main Aug 18, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@VladLasitsa @kibanamachine
@flash1293 @Mpdreamz
[XY] Remove vis type xy renderer (elastic#138735)
564ea41 
* Remove vis type xy renderer

* Fix check

* Remove unused translations

* Some

* Updated limits

* Update limits

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@jbudz jbudz jbudz approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VladLasitsa @elasticmachine @flash1293 @kibana-ci @jbudz @MichaelMarcialis @mbondyra @kibanamachine