WebGLProgram: add meshLine to list of parameter names #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to distinguish WebGLProgram instances that use mesh lines from those that don't. This is done based on a so called program code, which is, besides other things, based on the list of known parameter values for the parameters names from the parameter list. If two materials only differ in whether they use mesh lines and the one that doesn't is loaded first, then without this change no new program will be generated if the material with enabled mesh lines is loaded afterwards, which effectively disables mesh lines for this material.
|
Thanks! |
Mugen87
pushed a commit
that referenced
this pull request
May 7, 2017
clarified type of first param to constructor
Mugen87
pushed a commit
that referenced
this pull request
Jul 7, 2017
…-in-data.children-in-ObjectLoader.parseObject Updated Objectoader.parseObject. Changed the way of iterating over data.children array mrdoob#11432
Mugen87
pushed a commit
that referenced
this pull request
Dec 25, 2017
Mugen87
pushed a commit
that referenced
this pull request
Jan 28, 2018
Matrix4 - description for matrix and matrixWorld items in mrdoob#13183
Mugen87
pushed a commit
that referenced
this pull request
Feb 25, 2018
Remove the SceneLoader console error log
Mugen87
pushed a commit
that referenced
this pull request
Nov 1, 2018
Update the changes form the origin repo.
Mugen87
pushed a commit
that referenced
this pull request
Oct 23, 2019
.getPlane method needs a Plane as a target
Mugen87
pushed a commit
that referenced
this pull request
Feb 27, 2020
Mugen87
pushed a commit
that referenced
this pull request
Mar 11, 2020
Mugen87
pushed a commit
that referenced
this pull request
Nov 18, 2020
Read object name from .3dm file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to distinguish WebGLProgram instances that use mesh lines from those that don't. This is done based on a so called program code, which is, besides other things, based on the list of known parameter values for the parameters names from the parameter list. If two materials only differ in whether they use mesh lines and the one that doesn't is loaded first, then without this change no new program will be generated if the material with enabled mesh lines is loaded afterwards, which effectively disables mesh lines for this material.