[CLEANUP] Move CSS comment removal to separate method #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposed solution in #334 for retaining `@import` rules has a flaw: it may keep such rules that were commented-out. By separating out the comment removal from other CSS parsing, we can avoid that pitfall. Also optimized the regex for CSS comments by unfolding and using possessive quantifiers, potentially avoiding catastrophic failure. Part of #338.
oliverklee
approved these changes
Sep 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed solution in #334 for retaining
@importrules has a flaw: it maykeep such rules that were commented-out.
By separating out the comment removal from other CSS parsing, we can avoid that
pitfall.
Also optimized the regex for CSS comments by unfolding and using possessive
quantifiers, potentially avoiding catastrophic failure.
Part of #338.