Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Move CSS comment removal to separate method #728

Merged
merged 1 commit into from
Sep 28, 2019
Merged

[CLEANUP] Move CSS comment removal to separate method #728

merged 1 commit into from
Sep 28, 2019

Commits on Sep 28, 2019

  1. [CLEANUP] Move CSS comment removal to separate method 

    The proposed solution in #334 for retaining `@import` rules has a flaw: it may
keep such rules that were commented-out.

By separating out the comment removal from other CSS parsing, we can avoid that
pitfall.

Also optimized the regex for CSS comments by unfolding and using possessive
quantifiers, potentially avoiding catastrophic failure.

Part of #338.
    @JakeQZ
    JakeQZ committed Sep 28, 2019
    Configuration menu
    Copy the full SHA
    673d31c View commit details
    Browse the repository at this point in the history