Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new MARBL interface to initialize Chl #314

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Use new MARBL interface to initialize Chl #314

merged 4 commits into from
Oct 30, 2024

Conversation

mnlevy1981
Copy link
Collaborator

Total chlorophyll is set to 0 initially, and is not updated until after the first time MOM6 calls get_chl_from_model. This causes two problems:

  1. We do not want to compute swpen based on 0 chlorophyll in the first time step
  2. Restart tests to fail, because total chlorophyll was being reset back to 0 in the first time step of the restart

There are two related fixes in this commit:

  1. All interior tendency / surface flux outputs from MARBL are now in the restart file, so the model passes ERS tests
  2. If total chlorophyll was not initialized from a restart file, it is computed based on the initial values of the MARBL tracers (which could be from an IC file or a restart file)

@mnlevy1981
Use new MARBL interface to initialize Chl
5a29730 
Total chlorophyll is set to 0 initially, and is not updated until after the
first time MOM6 calls get_chl_from_model. This causes two problems:
1. We do not want to compute swpen based on 0 chlorophyll in the first time
step
2. Restart tests to fail, because total chlorophyll was being reset back to 0
in the first time step of the restart

There are two related fixes in this commit:
1. All interior tendency / surface flux outputs from MARBL are now in the
restart file, so the model passes ERS tests
2. If total chlorophyll was not initialized from a restart file, it is computed
based on the initial values of the MARBL tracers (which could be from an IC
file or a restart file)
@mnlevy1981
Copy link
Collaborator Author

This pull request depends on marbl-ecosys/MARBL#474; it shouldn't be merged until MARBL has been updated, and then MOM_interface will need to be updated with the new MARBL tag as well. I thought the changes I made to config_src/external/MARBL/marbl_interface.F90 would be sufficient to pass the CI tests, but looks like I messed something up there...

@mnlevy1981
Add short_name to marbl_single_output_type
d9aa6b4 
The dummy cap did not contain a component of marbl_single_output_type that I am
now using in MARBL_tracers.F90
@mnlevy1981
Fix comment that exceeded line-length
2b07520
@mnlevy1981
Clean-up following review
bff4d2a 
Instead of passing G -> register_MARBL_tracers(), can use HI to determine i,j
extent of CS%SFO and CS%ITO. Also, change order of k and m loops for better
memory management (and condense double-loops to a single line)
@mnlevy1981 mnlevy1981 marked this pull request as ready for review October 22, 2024 16:28
@mnlevy1981
Copy link
Collaborator Author

This requires marbl0.48.2; @klindsay28 and I reviewed it together (and bff4d2a addresses a couple small issues we found), but I'm happy to make additional updates if requested

@mnlevy1981 mnlevy1981 self-assigned this Oct 22, 2024
@mnlevy1981
Copy link
Collaborator Author

Forgot to mention testing -- I ran aux_mom_MARBL and pr_mom. All the aux_mom_MARBL tests are passing except the ERS test is giving ModuleNotFoundError: No module named 'imp' when trying to create the cice namelist for the continuation run. I'm rerunning that one test, but I've run other ERS tests and they've passed, so that issue seems to be beyond the scope of this PR.

With the pr_mom tests, I'm seeing comparison tests from DIMCSL_Ld1.TL319_t232.G_JRA.derecho_intel.mom-cfc_mods and ERI.TL319_t232.G_JRA.derecho_intel.mom-debug but I think these are expected?

2	FAIL
	2	COMPARE (FAIL)
      1 DIMCSL_Ld1.TL319_t232.G_JRA.derecho_intel.mom-cfc_mods
      1 ERI.TL319_t232.G_JRA.derecho_intel.mom-debug

I didn't run baseline comparisons from the CESM suite -- I expect answers to change for all the MARBL tests, and I didn't touch any non-MARBL modules (plus the CI testing all passed)

@mnlevy1981 mnlevy1981 merged commit a73cd49 into NCAR:dev/ncar Oct 30, 2024
10 checks passed
@mnlevy1981 mnlevy1981 deleted the initialize_chl branch October 30, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-marques gustavo-marques gustavo-marques approved these changes

@alperaltuntas alperaltuntas Awaiting requested review from alperaltuntas

Assignees

@mnlevy1981 mnlevy1981

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnlevy1981 @gustavo-marques