Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new MARBL interface to initialize Chl #314

Merged
merged 4 commits into from
Oct 30, 2024

Commits on Oct 17, 2024

  1. Use new MARBL interface to initialize Chl

    Total chlorophyll is set to 0 initially, and is not updated until after the
    first time MOM6 calls get_chl_from_model. This causes two problems:
    1. We do not want to compute swpen based on 0 chlorophyll in the first time
    step
    2. Restart tests to fail, because total chlorophyll was being reset back to 0
    in the first time step of the restart
    
    There are two related fixes in this commit:
    1. All interior tendency / surface flux outputs from MARBL are now in the
    restart file, so the model passes ERS tests
    2. If total chlorophyll was not initialized from a restart file, it is computed
    based on the initial values of the MARBL tracers (which could be from an IC
    file or a restart file)
    mnlevy1981 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5a29730 View commit details
    Browse the repository at this point in the history
  2. Add short_name to marbl_single_output_type

    The dummy cap did not contain a component of marbl_single_output_type that I am
    now using in MARBL_tracers.F90
    mnlevy1981 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d9aa6b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2b07520 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Clean-up following review

    Instead of passing G -> register_MARBL_tracers(), can use HI to determine i,j
    extent of CS%SFO and CS%ITO. Also, change order of k and m loops for better
    memory management (and condense double-loops to a single line)
    mnlevy1981 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bff4d2a View commit details
    Browse the repository at this point in the history