Fix the NSF award API endpoint #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the default grantsUrl to point to a proxy relative to the repository’s domain - Remove unused getGrant method from the LookupModel - Use native fetch API instead of jQuery.ajax to retrieve grants - Show spinner to indicate that grants are being retrieved (was set up but not used) - Move some logic from the getGrantAutocomplete method to new, smaller methods - Add missing JS docs - Add error handling Issue #2233
|
@rushirajnenuji, no rush, but if would you have a chance to give this a quick test to make sure everything's ok? You should only need to set the theme to "arctic" in order for the funding autocomplete field to work in the editor. |
|
Thank you @robyngit -- I'll test it out and get back to you. |
|
@rushirajnenuji forgot to point out that I did identify some improvements that are needed to this in the future: #2243 (just to save you some time in case you come to the same conclusions) |
rushirajnenuji
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Reviewed these changes on my local instance of MetacatUI and they look good. Thank you for getting this fix in @robyngit!
|
Thanks @rushirajnenuji ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major part of the fix involved setting up the ADC proxy to point to the new NSF grants API endpoint, then using the proxy in MetacatUI rather than the endpoint directly since it doesn't support CORS. Other minor fixes and improvements made along the way include: