Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the NSF award API endpoint #2244

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fix the NSF award API endpoint #2244

merged 5 commits into from
Jan 31, 2024

Commits on Jan 11, 2024

  1. Update default grants endpoint to use new API 

    Issue #2233
    @robyngit
    robyngit committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    2568080 View commit details
    Browse the repository at this point in the history

  2. Standardize whitespace & fix typos in LookupModel 

    Issue #2233
    @robyngit
    robyngit committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5831d46 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Fix grant/funding lookup 

    - Update the default grantsUrl to point to a proxy relative to the repository’s domain
- Remove unused getGrant method from the LookupModel
- Use native fetch API instead of jQuery.ajax to retrieve grants
- Show spinner to indicate that grants are being retrieved (was set up but not used)
- Move some logic from the getGrantAutocomplete method to new, smaller methods
- Add missing JS docs
- Add error handling

Issue #2233
    @robyngit
    robyngit committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6316b35 View commit details
    Browse the repository at this point in the history

  2. Add guide for setting up awards API proxy 

    Issue #2233
    @robyngit
    robyngit committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c0033a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Add test for the findGrants method in LookupModel 

    Issue #2233
    @robyngit
    robyngit committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    131e81f View commit details
    Browse the repository at this point in the history