Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: "404" Screen for when the disease does not exist. #12

Closed
4 tasks
bryanpizzillo opened this issue May 21, 2020 · 0 comments · Fixed by #40
Closed
4 tasks

Story: "404" Screen for when the disease does not exist. #12

bryanpizzillo opened this issue May 21, 2020 · 0 comments · Fixed by #40
Assignees
Labels
SP:2 2 Story Points story
Milestone

Comments

@bryanpizzillo
Copy link
Member

bryanpizzillo commented May 21, 2020

As a user, I want to know that I entered the wrong disease code by being presented with a 404 page so that I can check my URL and ensure that I entered the correct information.

Use the 404 page that we use in other apps (glossary, drug dictionary, etc.)

ESTIMATE 2

Acceptance Criteria

Scenario: Page Not Found displays when a user views a dynamic listing page with invalid disease parameter
Given user navigates to “/C123455”
And "trialListingPageType" is set to "Disease"
When the user has entered an incorrect disease
Then the system redirects users to a 404 page 
     Then page title on error page is "Page Not Found"
     And the search bar appears below the text
     And the following links and texts exist on the page: "We can't find the page you're looking for." Visit the homepage, browse by cancer type, or use the search below." "Have a question? Get in touch."
  
      | https://www.cancer.gov          | homepage      | 
      | https://www.cancer.gov/types    | cancer type   | 
      | https://www.cancer.gov/contact  | Get in touch  |
And the system returns a 404 status code
Given the application returns a "Page not found" message
 Then the title tag should be "Page Not Found"
  Then the page should contain the markup <meta name="prerender-status-code" content="404">
Scenario: Page Load Analytics fires for a 404 with invalid disease
 Given "trialListingPageType" is set to "Disease"
    And "baseHost" is set to "http://localhost:3000"
    And "canonicalHost" is set to "https://www.cancer.gov"
    And "analyticsPublishedDate" is set to "02/02/2011"
    And "siteName" is set to "National Cancer Institute"
 When the user navigates to "/c123456"
   Then page title on error page is "Page Not Found"
    And browser waits
   Then there should be an analytics event with the following details

| key                                          | value                                            |
| type                                         | PageLoad                                         |
| event                                        | TrialListingPageApp:Load:PageNotFound            |
| page.name                                    | www.cancer.gov/c123456                           |
| page.title                                   | Page Not Found                                   |
| page.metaTitle                               | Page Not Found                                   |
| page.language                                | english                                          |
| page.type                                    | nciAppModulePage                                 |
| page.channel                                 | Clinical Trials                                  |
| page.contentGroup                            | Clinical Trials: Custom                          |
| page.additionalDetails.trialListingPageType  | disease                                          |

Resources:

  • Feature: JIRA Ticket #
  • Mockups: Here goes a URL to or the name of the mockup(s) in inVision
  • Web Page: Here goes a URL to an existing web page

Notes

Adding markup will allow a pre-renderer to detect the error and report the correct 404 status code.

Some complementary notes if necessary:

  • Here goes a quote from an email

  • Here goes whatever useful information can exist…

Solution

As had been designed, the higher order component that fetches the listing info will be responsible for showing the 404 when one of the parameters that is fetched returns a 404 from the API.

Prerequisites

  • required dependency for identifying the problem, scope and then solution for this issue
  • Short Spike Description - Issue #9999

Tasks

  • Add logic to CTLViewsHoC to display PageNotFound for 404s
  • Update unit test for CTLViewsHoC
  • Add integration tests

Technical Notes

  • More notes, or technical nuances/direction
@amydugan amydugan added SP:2 2 Story Points SP:3 3 Story Points labels May 21, 2020
@sarinapadilla sarinapadilla removed the SP:3 3 Story Points label Jan 29, 2021
@VictoriaSunNIH VictoriaSunNIH added this to the Sprint 1 milestone Feb 8, 2021
@sarinapadilla sarinapadilla removed this from the Sprint 1 milestone Feb 9, 2021
@VictoriaSunNIH VictoriaSunNIH changed the title Story: "404" Screen for when the disease or intervention does not exist. Story: "404" Screen for when the disease does not exist. Mar 16, 2021
@VictoriaSunNIH VictoriaSunNIH added this to the Sprint 3 milestone Mar 16, 2021
kate-mashkina pushed a commit that referenced this issue Mar 18, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
kate-mashkina pushed a commit that referenced this issue Mar 18, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
kate-mashkina pushed a commit that referenced this issue Mar 18, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
kate-mashkina pushed a commit that referenced this issue Mar 23, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
- made search box and button size relative
to the screen size on mobile
kate-mashkina pushed a commit that referenced this issue Mar 23, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
- made search box and button size relative
to the screen size on mobile
kate-mashkina pushed a commit that referenced this issue Mar 24, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
- made search box and button size relative
to the screen size on mobile
- added additional 404 proxy check
- added mock files
kate-mashkina pushed a commit that referenced this issue Apr 1, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
- made search box and button size relative
to the screen size on mobile
- added additional 404 proxy check
- added mock files
arcepaul pushed a commit that referenced this issue Apr 1, 2021
- enabled PageNotFound for 404 status
- added prerender meta tag
- added integration tests
- made search box and button size relative
to the screen size on mobile
- added additional 404 proxy check
- added mock files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SP:2 2 Story Points story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants