(#12) Page Not Found for Disease

[kate-mashkina]

• enabled PageNotFound for 404 status
• added prerender meta tag
• added integration tests

Closes #12

[kate-mashkina]

@VictoriaSunNIH @mworrest @alinai here are links for review : https://react-app-dev.cancer.gov/clinical-trials-listing-app/pr-40/c456667?cfg=0 and https://react-app-dev.cancer.gov/clinical-trials-listing-app/pr-40/chicken-nugget?cfg=0

[kate-mashkina]

@mworrest as we discussed, search bar and submit button are now full width at <641 px - please re-check the PR https://react-app-dev.cancer.gov/clinical-trials-listing-app/pr-40/c456667?cfg=0

[mworrest]

Looks good--thanks!

[alinai]

Looks good. Thanks @kate-mashkina!

[bryanpizzillo]

Please fix the proxy to support known 404 urls that should respond with a 404, and not litter the test output with file not found errors.

The example from the output:

[Error: ENOENT: no such file or directory, open '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/c123455.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/c123455.json'
}
No listing-information mock found for request.
    ✓ Page Load Analytics fires for a 404 on a disease dynamic listing page with non-existent c-code (2292ms)
[Error: ENOENT: no such file or directory, open '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/chicken-nugget.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/chicken-nugget.json'
}

Additionally I see another error in the logs:
(node:3270) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 preprocessor:close listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit

[kate-mashkina]

@bryanpizzillo I took care of the proxy.
The other error mentioned appears to be an obvious Cypress's issue and still outstanding (see here cypress-io/cypress#1305) - but the good thing is that Cypress assures it does not cause things to crash.
I've done more digging and the same issue was also present in drug dictionary tests( precisely at the 10th feature it would be logged... so it just happens that pageNotFound is the 10th)

[arcepaul]

blecch. So this came up in the app scan as having needed to be changed. @sarinapadilla those changes haven't been made yet, right?