-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#12) Page Not Found for Disease #40
Conversation
9c38b3d
to
3fbd446
Compare
3fbd446
to
e2e272a
Compare
@mworrest as we discussed, search bar and submit button are now full width at <641 px - please re-check the PR https://react-app-dev.cancer.gov/clinical-trials-listing-app/pr-40/c456667?cfg=0 |
Looks good--thanks! |
e2e272a
to
321ce76
Compare
Looks good. Thanks @kate-mashkina! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the proxy to support known 404 urls that should respond with a 404, and not litter the test output with file not found errors.
The example from the output:
[Error: ENOENT: no such file or directory, open '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/c123455.json'] {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/c123455.json'
}
No listing-information mock found for request.
✓ Page Load Analytics fires for a 404 on a disease dynamic listing page with non-existent c-code (2292ms)
[Error: ENOENT: no such file or directory, open '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/chicken-nugget.json'] {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/home/runner/work/clinical-trials-listing-app/clinical-trials-listing-app/support/mock-data/listing-information/chicken-nugget.json'
}
Additionally I see another error in the logs:
(node:3270) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 preprocessor:close listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
321ce76
to
b22bf85
Compare
@bryanpizzillo I took care of the proxy. |
@@ -0,0 +1 @@ | |||
{"Message":"Could not find codes 'c12345'."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blecch. So this came up in the app scan as having needed to be changed. @sarinapadilla those changes haven't been made yet, right?
- enabled PageNotFound for 404 status - added prerender meta tag - added integration tests - made search box and button size relative to the screen size on mobile - added additional 404 proxy check - added mock files
b22bf85
to
7d88266
Compare
Closes #12