Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nzOnClose is emitted for nz-alert before fade animation is finished #1666

Closed
dmytroyarmak opened this issue Jun 15, 2018 · 1 comment · Fixed by #1667
Closed

nzOnClose is emitted for nz-alert before fade animation is finished #1666

dmytroyarmak opened this issue Jun 15, 2018 · 1 comment · Fixed by #1667

Comments

@dmytroyarmak
Copy link
Contributor

Version

1.0.0

Environment

any

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-njncob

Steps to reproduce

Click close button of the alert

What is expected?

nzOnClose is emitted only when a fade animation is finished, so you will be able to see animation if you are controlling the visibility of alert with ngIf

What is actually happening?

nzOnClose is emitted immediately and as a result, ngIfon alert hides it before the animation is done

Other?
dmytroyarmak added a commit to dmytroyarmak/ng-zorro-antd that referenced this issue Jun 15, 2018
@dmytroyarmak
fix(module:nz-alert): emit close after fade animation is done
263f012 
Fixes NG-ZORRO#1666
@dmytroyarmak dmytroyarmak mentioned this issue Jun 15, 2018
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Jun 16, 2018
@dmytroyarmak @vthinkxie
fix(module:nz-alert): emit close after fade animation is done (#1667)
6b31ca3 
close #1666
@lock
Copy link

lock bot commented Jun 16, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 16, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@dmytroyarmak @vthinkxie
fix(module:nz-alert): emit close after fade animation is done (NG-ZOR…
e305f1f 
…RO#1667)

close NG-ZORRO#1666
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:nz-alert): emit close after fade animation is done dmytroyarmak/ng-zorro-antd
1 participant
@dmytroyarmak