Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated breadcrumbs should support routerLink #2254

Closed
ihym opened this issue Oct 10, 2018 · 10 comments
Closed

Auto-generated breadcrumbs should support routerLink #2254

ihym opened this issue Oct 10, 2018 · 10 comments

Comments

@ihym
Copy link

ihym commented Oct 10, 2018

What problem does this feature solve?

Stay in angular context while navigating using auto-generated breadcrumbs.

What does the proposed API look like?

Maybe 2 possible values for nzAutoGenerate input? (specifying the use of either routerLink or casual href)

@wzhudev
Copy link
Member

wzhudev commented Oct 10, 2018

Known problem. You can check this #2050 (comment).

Are you interested in fixing this? @ihym (But you cannot use routerLink I'm afraid, but a method which goes this.router.navigate and dynamic injection. Users can use ng-zorro-antd without RouterModule imported) Test may result in browser loosing connection with karma. But don't worry about it. You can just leave navigating untested. We can fix the spec after Angular fixes that issue.

And yeah. A new API is a good idea.

@ihym
Copy link
Author

ihym commented Oct 10, 2018

Sure, I'll look into this.

@wzhudev
Copy link
Member

wzhudev commented Oct 16, 2018

@ihym Have you started working on this? If not I am willing to take this over because this is of high priority.

@ihym
Copy link
Author

ihym commented Oct 16, 2018

@wendzhue I'm not sure if I'll find the time to finish it this week. Feel free to reassign.

@IssueHuntBot
Copy link

@BoostIO funded this issue with $50. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@hammalrn has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@wendzhue has started working. See it on IssueHunt

1 similar comment
@IssueHuntBot
Copy link

@wendzhue has started working. See it on IssueHunt

@IssueHuntBot
Copy link

@vthinkxie has stopped working. See it on IssueHunt

@IssueHuntBot
Copy link

@vthinkxie has rewarded. See it on IssueHunt

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants