Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:breadcrumb): navigate within angular #2283

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 16, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2254

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #2283 into master will decrease coverage by 0.03%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
- Coverage   95.89%   95.85%   -0.04%     
==========================================
  Files         485      485              
  Lines       12182    12187       +5     
  Branches     1638     1638              
==========================================
  Hits        11682    11682              
- Misses        143      147       +4     
- Partials      357      358       +1
Impacted Files Coverage Δ
components/breadcrumb/nz-breadcrumb.component.ts 87.23% <25%> (-8.01%) ⬇️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648da35...216a023. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie October 16, 2018 09:04
@wzhudev
Copy link
Member Author

wzhudev commented Oct 18, 2018

I downloaded the demo from stackblitz and everything was OK. But I still cannot test it because of Angular's bug.

@vthinkxie vthinkxie merged commit 0c41306 into NG-ZORRO:master Oct 18, 2018
@wzhudev wzhudev deleted the bread-nav branch October 25, 2018 04:17
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants