Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use nz-select in nz-modal would cases a problem #3213

Closed
haoyinag opened this issue Apr 3, 2019 · 4 comments
Closed

use nz-select in nz-modal would cases a problem #3213

haoyinag opened this issue Apr 3, 2019 · 4 comments
Assignees
@hsuanxyz
Labels
Component: Modal

Comments

@haoyinag
Copy link

haoyinag commented Apr 3, 2019

Reproduction link

https://ng-zorro-antd-start-a6ja5q.stackblitz.io/

Steps to reproduce

use nz-select in nz-modal

What is expected?

fix that btns not shown again

What is actually happening?

fix it

Environment Info
ng-zorro-antd 7.2.0
Browser chrome
@hsuanxyz hsuanxyz mentioned this issue Apr 9, 2019
Closed
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Apr 10, 2019
@hsuanxyz
fix(module:modal): integration problem with select component
f2c10ba 
close NG-ZORRO#3213
@hsuanxyz hsuanxyz mentioned this issue Apr 10, 2019
Merged
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Apr 19, 2019
@hsuanxyz
fix(module:modal): integration problem with select component
c5f9d8f 
close NG-ZORRO#3213
@renyuns
Copy link

renyuns commented Apr 22, 2019

i have the same problem,have you solve it?

@renyuns
Copy link

renyuns commented Apr 22, 2019

@hsuanxyz 我的也是,自定义了 footer,然后关闭的时候还是出现取消确定按钮,我自定义 footer 为 提交了,不知道啥问题, 7.2.0 版本

@vthinkxie
Copy link
Member

@renyuns 修复的问题只会在最新版本（目前是7.3.1）上体现，旧版本是不会自动修改代码的

@renyuns
Copy link

renyuns commented Apr 22, 2019

@vthinkxie 好的,谢谢了,我更新到 7.3.1 了,这个问题解决了

andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@hsuanxyz @andrew-yangy
fix(module:modal): integration problem with select component (NG-ZORR…
d397b17 
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz @Ricbet
fix(module:modal): integration problem with select component (NG-ZORR…
4af0013 
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz @vthinkxie
fix(module:modal): integration problem with select component (NG-ZORR…
ee80d9d 
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
Component: Modal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vthinkxie @wzhudev @renyuns @hsuanxyz @haoyinag