Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): integration problem with select component #3245

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3213

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #3245 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   97.47%   97.47%   -0.01%     
==========================================
  Files         607      606       -1     
  Lines       11865    11861       -4     
  Branches      866      867       +1     
==========================================
- Hits        11566    11562       -4     
  Misses        190      190              
  Partials      109      109
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 99.04% <100%> (ø) ⬆️
components/form/nz-form-control.component.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ac541...c0720e0. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit c0720e0

https://deploy-preview-3245--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz force-pushed the fix/select-in-modal branch from f2c10ba to c5f9d8f Compare April 19, 2019 06:53
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 3da4b68 into NG-ZORRO:master Apr 19, 2019
@hsuanxyz hsuanxyz deleted the fix/select-in-modal branch April 22, 2019 02:39
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…O#3245)

* fix(module:modal): integration problem with select component

close NG-ZORRO#3213

* style: fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants