-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix some TS build issues in templates #2554
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2554 +/- ##
==========================================
+ Coverage 95.57% 95.61% +0.04%
==========================================
Files 507 495 -12
Lines 12086 12075 -11
Branches 1701 1687 -14
==========================================
- Hits 11551 11546 -5
+ Misses 171 169 -2
+ Partials 364 360 -4
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 156b876 |
131cc37
to
696a6c4
Compare
@vthinkxie any thoughts on this? |
696a6c4
to
e594472
Compare
@@ -7,6 +7,9 @@ export interface NzMessageConfig { | |||
nzAnimate?: boolean; | |||
// For message container only | |||
nzMaxStack?: number; | |||
nzTop?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nzMessage does not support nzTop | nzBottom | nzPlacement? any reason add these properties here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was because of nz-notification-container.component.html
using those properties, although I just realised that component is working with NzNotificationConfig
, which extends NzMessageConfig
.
I've updated the PR to reflect that in NzNotificationContainerComponent
, and I've also rebased it on master
.
Fixes _some_ of the issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates. Partially addresses NG-ZORRO#660, but still a long way to go.
e594472
to
156b876
Compare
Fixes some of the typing issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates.
Partially addresses #660, but still a long way to go.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #660
Including ng-zorro in projects with TS strict mode on results in build errors, such as these:
What is the new behavior?
Fixes some of the typing issues in HTML templates. Issues such as the ones described above are resolved.
Does this PR introduce a breaking change?
Other information