Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more strict tsconfig options #2884

Closed
7 tasks done
vthinkxie opened this issue Feb 13, 2019 · 4 comments
Closed
7 tasks done

more strict tsconfig options #2884

vthinkxie opened this issue Feb 13, 2019 · 4 comments
Assignees

Comments

@vthinkxie
Copy link
Member

vthinkxie commented Feb 13, 2019

Should add

{
    "noUnusedParameters": true,
    "noUnusedLocals": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "noImplicitAny": true,
    "noImplicitThis": true,
    "skipLibCheck": true,
}

in tsconfig.json -> compilerOptions .

@wzhudev

This comment has been minimized.

@aigoncharov
Copy link

Just FYI, with "strict" set to true currently ng build --prod fails with:

ERROR in node_modules/ng-zorro-antd/ng-zorro-antd.d.ts.ɵjd.html(3,3): : Object is possibly 'undefined'.
node_modules/ng-zorro-antd/ng-zorro-antd.d.ts.ɵjd.html(2,3): : Object is possibly 'undefined'.

If I set "strictNullChecks" to false it passes.

@wzhudev
Copy link
Member

wzhudev commented Feb 13, 2019

@keenondrums Yeah that's a known problem. We would try to fix tslint related problems in pull requests regarding this issue.

@wzhudev
Copy link
Member

wzhudev commented Mar 13, 2019

🎉 Finally!

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants