-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add strictNullCheck config #2977
Conversation
@wilsoncook @cipchk @vthinkxie @hsuanxyz @simplejason Please review code of the components you are in charge of. In case of any state related bug introduced. Notes for further development:
Modules acquire additional attention:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我提了几处语法建议,我不确定这些变更是否可能会影响到一些测试用例。
08d4113
to
6d538b1
Compare
@simplejason 我注意到 nz-tree-base 的 formatEvent 方法返回的 NzFormatEmitEvent 被各个 subject 用来 emit 事件, 但是不同 subject emit 的事件对于字段的 optional 要求是不一样的, 我添加了一些 Required (typescript 的类型修饰符), 请检查一下会不会有问题. 另外请加查一下 NzTreeNode 各个字段是否是必须的, 在不带来 break change 的前提下, |
57665be
to
26a91f6
Compare
Deploy preview for ng-zorro-master ready! Built with commit 26a91f6 |
Deploy preview for ng-zorro-master ready! Built with commit 03aa3bf |
Codecov Report
@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
+ Coverage 97.32% 97.32% +<.01%
==========================================
Files 549 550 +1
Lines 11489 11495 +6
Branches 815 817 +2
==========================================
+ Hits 11182 11188 +6
- Misses 197 199 +2
+ Partials 110 108 -2
Continue to review full report at Codecov.
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information