fix(module:tooltip): fix tooltip accessing destroyed view

[wzhudev]

close #3875
close #4317
close #4386

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[netlify]

Deploy preview for ng-zorro-master ready!

Built with commit 455d90c

https://deploy-preview-4387--ng-zorro-master.netlify.com

[codecov]

Codecov Report

Merging #4387 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
+ Coverage   92.11%   92.23%   +0.12%     
==========================================
  Files         521      521              
  Lines       11078    11082       +4     
  Branches     2010     2010              
==========================================
+ Hits        10205    10222      +17     
+ Misses        446      436      -10     
+ Partials      427      424       -3

Impacted Files	Coverage Δ
...mponents/tooltip/base/nz-tooltip-base.directive.ts	93.75% <100%> (+0.17%)	⬆️
components/select/nz-select.service.ts	86.22% <0%> (+2.63%)	⬆️
components/core/addon/string_template_outlet.ts	84% <0%> (+16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a71c43...455d90c. Read the comment docs.

[wzhudev]

Tested with the reproduction in #4386. This fix works.

[simplejason]

LGTM

[Svetomechc]

That's what happens after this PR if you try to go to a different route from a button with nz-tooltip (it was fine in 8.4.1 and before). The whole app becomes unusable after that until you hit F5.

[wzhudev]

@Svetomechc Could you make a reproduction? It looks that calling hide in ngOnDestroy is redundant...

[Svetomechc]

Okay, @wendzhue, created a reproduction. This is a pretty serious error which made me revert to 8.4.1.

UPD: Turns out it happens in previous versions too. I didn't notice it before because the error only happens in development mode, not in production.

[wzhudev]

@Svetomechc Great! I will test it with my latest fix. Thank you very much.

[Svetomechc]

@wendzhue no problem! I should be the one thanking you for maintaining this awesome library (:
It's only a pleasure to help you guys hunt down and squeeze some bugs.

[wzhudev]

It should be fixed in #4418.

[Svetomechc]

@wendzhue thx! Looking forward to 8.5.1 :3