Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build & unit testing #729

Open
AlexanderRichert-NOAA opened this issue Dec 7, 2023 · 3 comments
Open

Add CI build & unit testing #729

AlexanderRichert-NOAA opened this issue Dec 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@AlexanderRichert-NOAA
Copy link
Contributor

Description

Creating this issue to discuss and plan the addition of CI workflows to the repository for building and testing all code modifications.

Solution

I've added a GCC-and-MPICH-based CI workflow in my fork; currently it only builds, I have not added any tests: https://github.com/AlexanderRichert-NOAA/fv3atm/tree/develop
Here's my first successful run of the CI, which currently has two jobs, for building with 32 and 64 bit reals: https://github.com/AlexanderRichert-NOAA/fv3atm/actions/runs/7122152262

Next steps

If the CI so far looks good, then the main next step is to add unit tests with CTest. I would recommend we add a checklist to this issue to establish at least two or three initial tests, merge it into develop, then create one or more issues for adding further tests. Other possible additions we can discuss include the use of Intel, other MPI flavors, code coverage checks, and documentation (e.g., Doxygen).

@AlexanderRichert-NOAA AlexanderRichert-NOAA added the enhancement New feature or request label Dec 7, 2023
@AlexanderRichert-NOAA
Copy link
Contributor Author

@edwardhartnett
Copy link
Contributor

This is great progress. Can you put up a PR with the changes needed and the workflows?

@AlexanderRichert-NOAA
Copy link
Contributor Author

See #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants