Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build #730

Merged
merged 17 commits into from
Jan 12, 2024
Merged

Add CI build #730

merged 17 commits into from
Jan 12, 2024

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Dec 7, 2023

Description

This PR adds a GCC11-and-MPICH-based CI workflow for building fv3atm, on top of which unit tests can be added. Dependencies are installed through Spack, where the installation directory is cached between runs for a significant speed up.

Issue(s) addressed

Addresses #729

Testing

Tested standalone build on personal machine and GH Actions. Built under ufs-weather-model on personal machine.

Dependencies

none

@edwardhartnett
Copy link
Contributor

@junwang-noaa can you review this PR? This is needed for both documentation and unit testing work.

CMakeLists.txt Outdated Show resolved Hide resolved
@edwardhartnett
Copy link
Contributor

@AlexanderRichert-NOAA when the UFS is build by spack, is fv3atm one of the packages it builds?

Or does it build fv3atm as part of another package, using the git submodule method to get the fv3atm code?

@AlexanderRichert-NOAA
Copy link
Contributor Author

The CMakeLists.txt of ufs-weather-model uses add_subdirectory(FV3), where FV3 is the name of the fv3atm repository, which is accessed as a git submodule.

@AlexanderRichert-NOAA
Copy link
Contributor Author

@AlexanderRichert-NOAA
Copy link
Contributor Author

@edwardhartnett if you're able to approve this I think it's good to go

@AlexanderRichert-NOAA
Copy link
Contributor Author

@junwang-noaa can you recommend a second "approved" reviewer (I take it that Ed is not one)? If we can get this merged, I'll follow it up with the addition of the unit test infrastructure, including the first one or two unit tests.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jan 11, 2024

@BrianCurtis-NOAA Dusan is on leave, I added you to review. Please note that other FV3 PRs may need to be synced when this PR is committed. Thanks

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i look forward to seeing how this works!

@AlexanderRichert-NOAA
Copy link
Contributor Author

@junwang-noaa I believe this is ready to be merged

@junwang-noaa junwang-noaa merged commit 138aab1 into NOAA-EMC:develop Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants