Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit testing #752

Closed
wants to merge 53 commits into from
Closed

Add unit testing #752

wants to merge 53 commits into from

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jan 13, 2024 •
edited
Loading

Description

This PR:

  • Adds unit testing with the CTest framework, plus code coverage checking with gcovr; and
  • adds a proposed update to the PR template that has checkboxes for contributors to certify that they are appropriately adding unit tests and documentation to the code.

I relocated the build/ directory in the CI to be under the fv3atm repo directory because it made the gcovr setup simpler. I've also added some logic that ensures that the gcovr report and doxygen output only get generated for one of the jobs, but still under GCC.yml to keep things consolidated.

Issue(s) addressed

Addresses #729

Testing

Tested on personal computer. All CI jobs successful.

Dependencies

none

@AlexanderRichert-NOAA
get 'uppercase' from mpp_mod in io/module_wrt_grid_comp.F90
754531f
@AlexanderRichert-NOAA
Add GCC-based CI build
8d3927c
@AlexanderRichert-NOAA
note dep build time in GCC CI
8c1fac8
@AlexanderRichert-NOAA
Update CMakeLists.txt
435bccd
@AlexanderRichert-NOAA
Update spack.yaml
ca53742
@AlexanderRichert-NOAA
Update CMakeLists.txt
08d8e10
@AlexanderRichert-NOAA
Update spack.yaml
06d17f7
@BrianCurtis-NOAA
switch to use fms implementation of mpp
ca94767
@jkbk2004
Merge remote-tracking branch 'upstream/develop' into use_fms_mpp
630a2f7
@AlexanderRichert-NOAA
revert stoch phys name change
01bb3e2
@AlexanderRichert-NOAA
Merge remote-tracking branch 'brian/use_fms_mpp' into add_ci
773262c
@AlexanderRichert-NOAA
Update GCC.yml (remove fms recipe workaround)
d0a7c24
@AlexanderRichert-NOAA
rename stochastic_physics repo dir->stochastic_physics_repo
b73d804
@AlexanderRichert-NOAA
remove apt mpi installation
435f4d0
@AlexanderRichert-NOAA
increment cache key
e993d15
@AlexanderRichert-NOAA
Merge remote-tracking branch 'noaaemc/develop' into add_ci
764d250
@AlexanderRichert-NOAA
Merge remote-tracking branch 'origin/develop' into add_ci
dfc689a
@AlexanderRichert-NOAA
Add CI testing w/CTest & gcovr, + initial unit tests
7d520aa 
Create separate developer.yml CI workflow
@AlexanderRichert-NOAA
Update PR template
f4434a2
@AlexanderRichert-NOAA
Merge remote-tracking branch 'noaaemc/develop' into add_unit_testing
41a9a00
@AlexanderRichert-NOAA
complete test_fv3_io_def.F90
f6cca88
@AlexanderRichert-NOAA
Update pull_request_template.md
bb31535
@AlexanderRichert-NOAA
fix testrun build path in GCC.yml
aaf587b
@AlexanderRichert-NOAA
catch one more case in post_nems_routine unit test
a309fb8
@AlexanderRichert-NOAA
fix test_post_nems_routines.F90
4360aee
@AlexanderRichert-NOAA
Update CMakeLists.txt
ba5f71d
@AlexanderRichert-NOAA
simplify test_fv3_io_def.F90
a4f5a26
@AlexanderRichert-NOAA
Merge remote-tracking branch 'noaaemc/develop' into add_unit_testing
df302ed
@AlexanderRichert-NOAA
Re-integrate developer.yml into GCC.yml
99c197f
@AlexanderRichert-NOAA
refine cache condition in GCC.yml
e6c41db
@AlexanderRichert-NOAA
Copy link
Contributor Author

@junwang-noaa please review. I suggest squash & merge.

@junwang-noaa
Copy link
Collaborator

@DusanJovic-NOAA Do we have an fv3 PR that will be committed in the upcoming ufs wm commites? Can we coordinate it with this one (ask the person to merge fv3atm when this PR is committed)? Thanks

@DusanJovic-NOAA
Copy link
Collaborator

I see #767 scheduled for merge in the ufs-weather-model commit queue. @grantfirl can you please merge this branch with your #767 PR. This PR updates github workflow to run unit tests.

@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request Mar 21, 2024
Closed
@AlexanderRichert-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA I've merged in the current develop branch so it includes your changes. Otherwise everything should basically be as it was before.

@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request Jun 27, 2024
Merged
2 tasks
@climbfuji
Copy link
Collaborator

Pulled into #798

DusanJovic-NOAA pushed a commit that referenced this pull request Aug 8, 2024
@climbfuji @AlexanderRichert-NOAA @dustinswales
Convert GFS DDTs from blocked data structures to contiguous arrays (n…
aa14843 
…ow also includes #752) (#798)

* Convert GFS_grid DDT: use contiguous arrays instead of blocked data structures
* Add GCC-based CI build

---------

Co-authored-by: Alex Richert <alexander.richert@noaa.gov>
Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
@DusanJovic-NOAA
Copy link
Collaborator

Merged via #798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexanderRichert-NOAA @junwang-noaa @DusanJovic-NOAA @climbfuji @BrianCurtis-NOAA @jkbk2004