Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider surface ocean current in air-sea flux calculation #755

Merged
merged 75 commits into from
Feb 1, 2024

Conversation

binli2337
Copy link
Collaborator

@binli2337 binli2337 commented Jan 14, 2024

Description

This PR will update ccpp-physics and GFDL_atmos_cubed_sphere components to include surface ocean current in the computation of air-sea fluxes.

This PR will also add a new namelist called "icplocn2atm."
When icplocn2atm=0, surface ocean current is not used in the computation of air-sea fluxes.
When icpocn2atm=1, surface ocean current is used in the computation of air-sea fluxes.

Issue(s) addressed

Testing

How were these changes tested? The changes were tested in the HAFS-MOM6 system.
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
New tests will not be added to UFS regression test system.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. No
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

Co-authored-by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

BinLiu-NOAA and others added 30 commits April 14, 2022 21:22
…and allow one to override data integrity checks in FMS restart logic
…hafsv0.3_final

Conflicts:
	atmos_cubed_sphere
…nLiu-NOAA):

suite_FV3_HAFS_v0_thompson.xml
suite_FV3_HAFS_v0_thompson_nonsst.xml
suite_FV3_HAFS_v0_thompson_noahmp.xml
suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml
…ling time

steps). This is to reduce the overhead introduced by downscaling the coupling
variables from FV3ATM parent to nest.
…FS sa-TKE

EDMF PBL scheme for HAFS/hurricane modeling.
in internal tracker output (fort.602, phtcf file).
Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK to me, but someone w/ more familiarity w/ the moving nest code should also review.

Copy link
Collaborator

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested under HAFS application already.

@grantfirl
Copy link
Collaborator

ufs-community/ccpp-physics#155 was merged. This PR branch is ready to revert .gitmodules and commit the latest ufs/dev hash of ccpp-physics: ufs-community/ccpp-physics@51452b8

@BinLiu-NOAA
Copy link
Collaborator

ufs-community/ccpp-physics#155 was merged. This PR branch is ready to revert .gitmodules and commit the latest ufs/dev hash of ccpp-physics: ufs-community/ccpp-physics@51452b8

Thanks, @grantfirl!

Waiting for NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/311 being merged.

@zach1221
Copy link
Collaborator

zach1221 commented Feb 1, 2024

atmos_cubed_sphere hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@6663459

@zach1221
Copy link
Collaborator

zach1221 commented Feb 1, 2024

@jkbk2004 We have approvals here, can you please merge this PR?

@jkbk2004 jkbk2004 merged commit 8db821c into NOAA-EMC:develop Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet