-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider surface ocean current in air-sea flux calculation #755
Consider surface ocean current in air-sea flux calculation #755
Conversation
…and allow one to override data integrity checks in FMS restart logic
…hafsv0.3_final Conflicts: atmos_cubed_sphere
…nLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml
…sing the prime meridian.
…ling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest.
…branch of the hafs-community fork.
…unity/fv3atm into feature/hafsv0.3_final
…FS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling.
in internal tracker output (fort.602, phtcf file).
…re and ccpp-physics.
…#622) * fix initialization for moving nest grid
…hafsv2_baseline_with_ssc
and suite_FV3_HAFS_v1_thompson_nonsst.xml under ccpp/suites since they are used by operational HAFS configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look OK to me, but someone w/ more familiarity w/ the moving nest code should also review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested under HAFS application already.
ufs-community/ccpp-physics#155 was merged. This PR branch is ready to revert .gitmodules and commit the latest ufs/dev hash of ccpp-physics: ufs-community/ccpp-physics@51452b8 |
Thanks, @grantfirl! Waiting for NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/311 being merged. |
atmos_cubed_sphere hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@6663459 |
@jkbk2004 We have approvals here, can you please merge this PR? |
Description
This PR will update ccpp-physics and GFDL_atmos_cubed_sphere components to include surface ocean current in the computation of air-sea fluxes.
This PR will also add a new namelist called "icplocn2atm."
When icplocn2atm=0, surface ocean current is not used in the computation of air-sea fluxes.
When icpocn2atm=1, surface ocean current is used in the computation of air-sea fluxes.
Issue(s) addressed
Testing
How were these changes tested? The changes were tested in the HAFS-MOM6 system.
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
New tests will not be added to UFS regression test system.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Co-authored-by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA