Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

binli2337 · 2024-01-19T08:51:04Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This PR adds capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling.

Commit Message

Enable the capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling. A namelist option is added to control whether or not to use this feature (default is off). Fixes #1975

Co-authored by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

Priority

Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
- Needed for HAFSv2 upgrade code freeze
Normal

Blocking Dependencies

Git Issues Fixed By This PR

Changes

Subcomponent (with links)

Input data

No changes are expected to input data.
Changes are expected to input data:
- New input data.
- Updated input data.

Regression Tests:

No changes are expected to any regression test.
Changes are expected to the following tests:

FAILED REGRESSION TESTS

Libraries

Not Needed
Needed
- Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
- Add issue link from JCSDA/spack-stack following this item

Testing Log:

RDHPCS
- Hera
- Orion
- Hercules
- Jet
- Gaea
- Derecho
WCOSS2
- Dogwood/Cactus
- Acorn
CI
- Completed
opnReqTest
- N/A
- Log attached to comment

jkbk2004 · 2024-01-26T21:16:15Z

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

…update_ssc

BinLiu-NOAA · 2024-01-27T15:14:44Z

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

@jkbk2004 This PR branch and all its submodules have been synced with their corresponding ufs-weather-model develop branch. Thanks!

BinLiu-NOAA · 2024-01-27T20:24:56Z

A quick follow-up is that, the full RT set went through on WCOSS2 successfully, confirming no answer changing for the baseline.

Meanwhile, a note is that, the gnv1_nested_intel test failed in the first try during result checking/comparing against baseline, however the second try of the gnv1_nested_intel test succeeded without issues. Another note is that, I encountered the similar issue (first try failed, second run succeeded) for this gnv1_nested_intel test while testing another PR branch.

With that, I think this PR/branch is ready to proceed for next steps. Thanks!

DeniseWorthen · 2024-01-29T17:23:05Z

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

zach1221 · 2024-01-29T19:22:15Z

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

BinLiu-NOAA · 2024-01-29T19:25:29Z

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

Thanks, @zach1221!

binli2337 · 2024-01-29T19:59:51Z

@DeniseWorthen Have you started the runs? I can do it.

DeniseWorthen · 2024-01-29T20:15:36Z

No, I have not started RTs (didn't think I needed to).

BinLiu-NOAA · 2024-01-29T20:30:23Z

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

zach1221 · 2024-01-29T20:58:11Z

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

Yes, I have them going. A little more than halfway there.

zach1221 · 2024-01-30T14:24:30Z

@binli2337 fyi, we're going to work PR #2098 currently and will work this one afterwards.

zach1221 · 2024-01-30T20:19:47Z

Hera logs attached. No changes.

RegressionTests_hera.log

zach1221 · 2024-01-31T15:51:51Z

@binli2337 can you please sync up your branch here? We'll begin testing against this PR next.

…-weather-model into feature/update_ssc

BinLiu-NOAA · 2024-01-31T20:48:08Z

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

zach1221 · 2024-02-01T02:37:36Z

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

Hi, @BinLiu-NOAA sorry for the late reply. Yes, the tests are running. We're working to get them finished as soon as possible. Brian should be taking care of WCOSS tests.

FernandoAndrade-NOAA · 2024-02-01T04:32:38Z

In addition to cpld_debug_gfsv17_intel, the hafs_regional_atm_ocn_wav_intel test has also failed with a timeout on Jet. However, it should be noted the failure was properly reported on the test summary at the end.

BinLiu-NOAA · 2024-02-01T13:41:00Z

Much appreciated, @zach1221, @FernandoAndrade-NOAA, @BrianCurtis-NOAA! Hopefully, the RTs will go through smoothly. Thanks!

zach1221 · 2024-02-01T18:28:48Z

Regression testing is complete. We can proceed with the merging process on ccpp-physics and cubed-sphere.
@binli2337 @BinLiu-NOAA

DeniseWorthen · 2024-02-01T18:40:16Z

@binli2337 cmeps is merged 8cd4a32

zach1221 · 2024-02-01T20:50:09Z

@binli2337 fv3atm is merged now as well. NOAA-EMC/fv3atm@8db821c

binli2337 · 2024-02-01T21:07:24Z

@zach1221 I will merge FV3 now.

binli2337 · 2024-02-01T21:14:49Z

It is ready for review. Thanks!

Update FV3 and CMEPS.

cce5373

BinLiu-NOAA changed the title ~~Consider sea surface ocean currents in the air-sea flux calculation~~ Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling Jan 19, 2024

BinLiu-NOAA added enhancement New feature or request No Baseline Change No Baseline Change labels Jan 19, 2024

binli2337 added 2 commits January 26, 2024 11:49

Update FV3 and CMEPS.

9f4e1f5

Merge branch 'develop' into feature/update_ssc

5e5d77d

DeniseWorthen assigned binli2337 Jan 26, 2024

jkbk2004 mentioned this pull request Jan 26, 2024

fix NSSL MP init issue when initialized from other microphysics schemes #2098

Merged

41 tasks

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

061b112

…update_ssc

BinLiu-NOAA added 3 commits January 27, 2024 15:42

Update submodule FV3.

abdbaaf

Update submodule FV3.

beb94e0

Add operational HAFS CCPP suites in the hafsw_faster build.

1353fb3

binli2337 added 2 commits January 30, 2024 14:18

Update FV3.

3e1b59d

Merge branch 'develop' into feature/update_ssc

4001253

zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jan 31, 2024

Merge branch 'feature/update_ssc' of https://github.com/binli2337/ufs…

2d9959c

…-weather-model into feature/update_ssc

FernandoAndrade-NOAA and others added 3 commits February 1, 2024 01:09

add hera RT log passed

58d06b0

add orion RT logs: passed

ea890c9

add derecho RT logs: passed

e0cc992

add jet RT log passed

290f403

zach1221 and others added 6 commits February 1, 2024 14:08

add control_p8_gnu ORT logs: passed

025ab76

add regional_control_gnu ORT logs: passed

a6a7b69

add cpld_control_gnu ORT logs: passed

9da9af3

WCOSS2 RT Log

fe31a76

Acorn RT Log

2e11465

add hercules RT logs: passed

a1d49d0

Update CMEPS and FV3.

403eea7

Update FV3.

f09eebb

zach1221 requested review from BrianCurtis-NOAA, SadeghTabas-NOAA and jkbk2004 February 1, 2024 21:12

BrianCurtis-NOAA approved these changes Feb 1, 2024

View reviewed changes

SadeghTabas-NOAA approved these changes Feb 1, 2024

View reviewed changes

zach1221 merged commit db98161 into ufs-community:develop Feb 1, 2024

grantfirl mentioned this pull request Mar 18, 2024

UFS-dev PR#155 NCAR/ufs-weather-model#128

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

binli2337 commented Jan 19, 2024 •

edited by zach1221

Loading

jkbk2004 commented Jan 26, 2024

BinLiu-NOAA commented Jan 27, 2024

BinLiu-NOAA commented Jan 27, 2024

DeniseWorthen commented Jan 29, 2024

zach1221 commented Jan 29, 2024

BinLiu-NOAA commented Jan 29, 2024

binli2337 commented Jan 29, 2024

DeniseWorthen commented Jan 29, 2024

BinLiu-NOAA commented Jan 29, 2024

zach1221 commented Jan 29, 2024

zach1221 commented Jan 30, 2024

zach1221 commented Jan 30, 2024 •

edited

Loading

zach1221 commented Jan 31, 2024

BinLiu-NOAA commented Jan 31, 2024

zach1221 commented Feb 1, 2024

FernandoAndrade-NOAA commented Feb 1, 2024 •

edited

Loading

BinLiu-NOAA commented Feb 1, 2024

zach1221 commented Feb 1, 2024

DeniseWorthen commented Feb 1, 2024

zach1221 commented Feb 1, 2024

binli2337 commented Feb 1, 2024

binli2337 commented Feb 1, 2024

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

Conversation

binli2337 commented Jan 19, 2024 • edited by zach1221 Loading

Commit Queue Requirements:

PR Information

Description

Commit Message

Priority

Blocking Dependencies

Git Issues Fixed By This PR

Changes

Subcomponent (with links)

Input data

Regression Tests:

Libraries

Testing Log:

jkbk2004 commented Jan 26, 2024

BinLiu-NOAA commented Jan 27, 2024

BinLiu-NOAA commented Jan 27, 2024

DeniseWorthen commented Jan 29, 2024

zach1221 commented Jan 29, 2024

BinLiu-NOAA commented Jan 29, 2024

binli2337 commented Jan 29, 2024

DeniseWorthen commented Jan 29, 2024

BinLiu-NOAA commented Jan 29, 2024

zach1221 commented Jan 29, 2024

zach1221 commented Jan 30, 2024

zach1221 commented Jan 30, 2024 • edited Loading

zach1221 commented Jan 31, 2024

BinLiu-NOAA commented Jan 31, 2024

zach1221 commented Feb 1, 2024

FernandoAndrade-NOAA commented Feb 1, 2024 • edited Loading

BinLiu-NOAA commented Feb 1, 2024

zach1221 commented Feb 1, 2024

DeniseWorthen commented Feb 1, 2024

zach1221 commented Feb 1, 2024

binli2337 commented Feb 1, 2024

binli2337 commented Feb 1, 2024

binli2337 commented Jan 19, 2024 •

edited by zach1221

Loading

zach1221 commented Jan 30, 2024 •

edited

Loading

FernandoAndrade-NOAA commented Feb 1, 2024 •

edited

Loading