Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure the approach to read in the Noah MP parameter table #1614

Closed
HelinWei-NOAA opened this issue May 16, 2023 · 8 comments · Fixed by #1697
Closed

restructure the approach to read in the Noah MP parameter table #1614

HelinWei-NOAA opened this issue May 16, 2023 · 8 comments · Fixed by #1697
Assignees
Labels
feature New feature or request
Milestone

Comments

@HelinWei-NOAA
Copy link
Contributor

Description
Noah MP parameter table is part of the source code in the current version. The UFS model has to be recompiled whenever there is any parameter change in the table. Therefore we propose to change this structure and the table will become one of the input file to the model.

Requirements
The Noah MP table has to be put somewhere in the global workflow and the running script needs to specify the path of this file (softlink or copy this file to the running directory)

Acceptance Criteria (Definition of Done)
I suggest this table file should be put into the directory parm. But I don't know which subdirectory? Or create a new one para_land?

ush/forecast_postdet.sh needs to be modified to link or copy this table file

@HelinWei-NOAA HelinWei-NOAA added the feature New feature or request label May 16, 2023
@aerorahul
Copy link
Contributor

@HelinWei-NOAA Thank you for opening this issue.
Is this file/table part of the ufs-weather-model repository? If so, we can pick directly from there into the global-workflow.

@JessicaMeixner-NOAA JessicaMeixner-NOAA added this to the HR2 milestone May 16, 2023
@HelinWei-NOAA
Copy link
Contributor Author

@aerorahul Yes. It can be part of the ufs-weather-model repository (under ccpp-physics)

@HelinWei-NOAA Thank you for opening this issue. Is this file/table part of the ufs-weather-model repository? If so, we can pick directly from there into the global-workflow.

@HelinWei-NOAA
Copy link
Contributor Author

@aerorahul What part of global workflow do we need to modify to accomplish this goal? Now the table is sitting in the ccpp-physics repo.

@WalterKolczynski-NOAA
Copy link
Contributor

@HelinWei-NOAA An entry needs to be added to sorc/link_workflow.sh to copy/link the appropriate file(s) from UFS to somewhere in parm (we can discuss where). Then one of the scripts for the forecast job (likely ush/forecast_postdet.sh or ush/parsing_namelists_FV3.sh) will need to be updated to copy the file from parm to the working directory when the forecast job runs. If workflow needs to allow multiple options for this file, a setting can be added to the fcst and efcs config files.

Are these tables templates that need to have information substituted at runtime, or are they static?

@HelinWei-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA Can we create a sub_dir para_land under parm and put this file here? The table is static and there is no information substituted at runtime.

@WalterKolczynski-NOAA
Copy link
Contributor

Create a new parm/ufs/land directory and put the new file(s) there.

@HelinWei-NOAA
Copy link
Contributor Author

HelinWei-NOAA commented Jul 17, 2023

@WalterKolczynski-NOAA I have created a branch for this PR. How can I link it here? Or I need to create a new PR?

@WalterKolczynski-NOAA
Copy link
Contributor

Depends.

  • If you just want to link it, you can just drop a link.

  • If you mention the issue in your commit message, that activity will appear here:

Do something

What the thing is and why thing was done.

Refs #1614
  • When you open a PR, you should attach it to the issue by using closing keywords in the description:
Description of what the PR does and why.

Resolves #1614

WalterKolczynski-NOAA pushed a commit that referenced this issue Jul 28, 2023
…able (#1697)

- A new soil color dataset is introduced to Noah MP to reflect the right soil albedo to reduce
the large warm bias found in the Sahel desert. The more-recent and higher resolution BNU
soil texture data will be used to replace the old data. 

- Noah MP parameter table is part of the source code in the current version. The UFS model
has to be recompiled whenever there is any parameter change in the table. Therefore we
change this structure and the table will become one of the input file to the model.

Closes #1614 
Closes #1617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
4 participants