Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the new soil color data and updating some of other LSC datasets #1617

Closed
4 tasks
HelinWei-NOAA opened this issue May 16, 2023 · 4 comments · Fixed by #1697
Closed
4 tasks

adding the new soil color data and updating some of other LSC datasets #1617

HelinWei-NOAA opened this issue May 16, 2023 · 4 comments · Fixed by #1697
Assignees
Labels
feature New feature or request Fix Files
Milestone

Comments

@HelinWei-NOAA
Copy link
Contributor

HelinWei-NOAA commented May 16, 2023

Description
A new soil color dataset is introduced to Noah MP to reflect the right soil albedo to reduce the large warm bias found in the Sahel desert. The more-recent and higher resolution BNU soil texture data will be used to replace the old data. We are still working to create the dataset for all resolutions. We came across some inconsistence issues. The land-sea mask or the grid we are using now may not be the same as to the one used to create the current dataset. The optimal goal is to recreate all surface fixed fields. But they may not be ready for HR2.

Requirements
The new data has to be put into the official fixed directory for global workflow and the data repo for RTs
The flag to the soil color dataset has to be added to parsing_namelists_FV3.sh

Tasks

@HelinWei-NOAA HelinWei-NOAA added the feature New feature or request label May 16, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA added this to the HR2 milestone May 16, 2023
@HelinWei-NOAA
Copy link
Contributor Author

HelinWei-NOAA commented May 30, 2023

The new dataset can be found from /scratch2/NCEPDEV/stmp1/Sanath.Kumar/repo_viirs30s_bnuv2 on hera. Can someone copy them to the authorized fixed directory? Then I can start to modify the workflow.

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Jun 15, 2023

Data has been copied into the master fix on Hera as orog version 20230615. You can update the fix version in versions/fix.ver. I will mirror it to other machines once verified.

Note I've changed the sub-directory name for the surface files from $RES/fix_sfc to $RES/sfc, so when you update the version in workflow you will also need to update that path. I believe that is only in ush/forecast_postdet.sh and parm/ufs/fix/gfs/land.fixed_files.yaml.

@HelinWei-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA I just created a PR 1696. What tests do you want me to do? The ufs code related to this change hasn't been committed to the develop branch yet. I need to use my personal branch to do any tests.

@WalterKolczynski-NOAA
Copy link
Contributor

I'm going to close that PR. Please open a new one and follow the PR template provided. Also, mark it as draft as we won't merge it until UFS has been updated.

For testing, we are starting to lean on CI testing a bit more. Run whatever tests you would normally run to make sure the changes are doing what you expect, and then we'll do additional testing with CI when everything is ready.

WalterKolczynski-NOAA pushed a commit that referenced this issue Jul 28, 2023
…able (#1697)

- A new soil color dataset is introduced to Noah MP to reflect the right soil albedo to reduce
the large warm bias found in the Sahel desert. The more-recent and higher resolution BNU
soil texture data will be used to replace the old data. 

- Noah MP parameter table is part of the source code in the current version. The UFS model
has to be recompiled whenever there is any parameter change in the table. Therefore we
change this structure and the table will become one of the input file to the model.

Closes #1614 
Closes #1617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Fix Files
Projects
None yet
3 participants