Make Atm_block, IPD_control, and IPD_Data public in SHiELD/atmos_model.F90

[spencerkclark]

Description

This PR makes the Atm_block, IPD_control, and IPD_data structures public in SHiELD/atmos_model.F90. This is needed for interaction within the Python-wrapped version of SHiELD under development starting with ai2cm/SHiELD-wrapper#1.

How Has This Been Tested?

These changes have been tested in ai2cm/SHiELD-wrapper#1. The continuous integration setup there builds the fortran model and its dependencies using the SHiELD_build COMPILE script, builds the Python wrapper, and runs several tests, including some that leverage interaction with these structures.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included

[lharris4]

I think this is fine; it merely exposes data structures outside of SHiELD which is useful.

[bensonr]

@lharris4 - and more importantly, these are not FV3 (dycore) elements where unexpected results can occur by an inadvertent overwrite of a data element.

[lharris4]

Glad that it doesn't have any potential side effects. Thanks for confirming.

…

On Wed, Oct 4, 2023 at 4:38 PM Rusty Benson ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#26 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVBJBH7QCLGWKN7ZUJ3X5XCM7AVCNFSM6AAAAAA5S5SBF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJYGQ2DIOJTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>