Split update_atmos_radiation_physics in SHiELD/atmos_model.F90
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
requested review from
laurenchilutti and
thomas-robinson
as code owners
|
@JosephMouallem could you weigh in with your progress or understanding of splitting up |
|
These changes are Ok for me. I have created a whole new driver to accommodate the full coupler routines and coupling variables as in this branch |
lharris4
approved these changes
Oct 19, 2023
|
Thanks for weighing in @JosephMouallem and for the review @lharris4. That's great that this split should not interfere with the coupling work. I've gone ahead and removed the "draft" designation from this PR. |
|
A gentle ping on reviewing this PR @bensonr @laurenchilutti. Thanks! |
bensonr
reviewed
Nov 1, 2023
spencerkclark
force-pushed
the
split-update_atmos_radiation_physics
branch
from
d409f1e
to
68832a8
Compare
bensonr
approved these changes
Nov 1, 2023
laurenchilutti
approved these changes
Nov 1, 2023
|
I'll go ahead and merge this and the associated SHiELD_physics PRs |
This was referenced Nov 1, 2023
spencerkclark
added a commit
to ai2cm/SHiELD-wrapper
that referenced
this pull request
Nov 1, 2023
This PR updates the dycore, physics, and driver NOAA-GFDL submodules in this repo to their latest `main` branches. Now that - NOAA-GFDL/SHiELD_physics#31 - NOAA-GFDL/atmos_drivers#31 - NOAA-GFDL/atmos_drivers#30 - NOAA-GFDL/GFDL_atmos_cubed_sphere#302 have been merged, all the required features in SHiELD are in place to bring SHiELD-wrapper up-to-par with fv3gfs-wrapper. Note that NOAA-GFDL/SHiELD_physics#31 made changes to the long names of some of the diagnostics output in our regression test, which required a checksum update. I have also taken the liberty to remove the disclaimer from the README that states that changes to SHiELD are required to bring SHiELD-wrapper up-to-par with FV3GFS. That is no longer a limiting factor, and those remaining features are implemented in open PRs in this repo.
spencerkclark
added a commit
to ai2cm/SHiELD-wrapper
that referenced
this pull request
Nov 3, 2023
This PR ports the changes in ai2cm/fv3gfs-fortran#317 to the SHiELD wrapper, which give us finer grained control over the steps of the time loop related to the physics. It depends on NOAA-GFDL/atmos_drivers#30, which was merged upstream and incorporated into this repository in #11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per our discussion today, this surfaces what is discussed in #27 as a PR for greater visibility (marking as a draft for now pending possible overlapping work by @JosephMouallem). It splits the
update_atmos_radiation_physicssubroutine into three parts:update_atmos_pre_radiationupdate_atmos_radiationupdate_atmos_physicsThe
update_atmos_radiation_physicssubroutine is retained and does exactly what it did before (so this does not change answers and requires no downstream code changes), but is written in a more modular fashion, exposing its steps as additional public subroutines inatmos_model_mod.Fixes #27
xref: ai2cm/fv3gfs-fortran#317 for how we proceeded with this in FV3GFS.
How Has This Been Tested?
On top of the changes in #26, this has been tested in CI within the SHiELD-wrapper repository. For the test configuration there, after these changes we get bit-for-bit identical results.
Checklist: