Remove re-checkout #102
Merged
Remove re-checkout #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcui007
requested review from
PhilMiller,
hellkite500,
program-- and
madMatchstick
PhilMiller
reviewed
Jan 5, 2024
| @@ -1,4 +1,4 @@ | |||
| # Test ngen-cfe integration | |||
| # Test ngen-smp integration | |||
There was a problem hiding this comment.
Suggested change
| # Test ngen-smp integration | |
| # Test ngen-cfe integration |
| @@ -20,7 +20,7 @@ env: | |||
| # A workflow run is made up of one or more jobs that can run sequentially or in parallel | |||
| jobs: | |||
| # Run general unit tests in linux environment | |||
| test_surfacebmi_plus_cfe: | |||
| test_smp: | |||
There was a problem hiding this comment.
Suggested change
| test_smp: | |
| test_cfe: |
|
Other than naming SMP vs CFE, this looks good to me. |
madMatchstick
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the re-checkout block of codes in the original
ngen_integration.yamlso the code is cleaner. Also, the CFE shared library build is updated to be consistent with CFE update.Additions
Removals
Changes
.github/workflows/ngen_integration.yaml
realizations/realization_cfe_pet_ngenCI.json
Testing
Passed all automated tests.
Screenshots
Notes
Todos
Checklist
Visually tested in supported browsers and devices (see checklist below 👇)Testing checklist
Target Environment support