Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove re-checkout #102

Merged
merged 5 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 24 additions & 37 deletions .github/workflows/ngen_integration.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Test ngen-cfe integration
# Test ngen-smp integration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Test ngen-smp integration
# Test ngen-cfe integration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

name: Ngen Integration Tests

Expand All @@ -20,7 +20,7 @@ env:
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
# Run general unit tests in linux environment
test_surfacebmi_plus_cfe:
test_smp:
# The type of runner that the job will run on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test_smp:
test_cfe:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

strategy:
matrix:
Expand All @@ -30,13 +30,27 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checkout and build the CFE
- name: Checkout the commit
uses: actions/checkout@v4

- name: Build the CFE Library
run: |
cmake -B cmake_build -S . -DNGEN=ON
make -C cmake_build

- name: Save CFE to a Temp Directory
run: |
# Move files to a temporary directory
mkdir ${{runner.temp}}/cfe
mv ./* ${{runner.temp}}/cfe

# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: checkout actions in another repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: noaa-owp/ngen

# Build some necessary submodules
- name: Build PET
id: submod_build_5
uses: ./.github/actions/ngen-submod-build
Expand All @@ -62,40 +76,13 @@ jobs:
bmi_c: 'ON'
timeout-minutes: 15

- name: Cleanup Ngen Build
run: |
# Move ngen build artifacts to temp directory
mv ${{ steps.ngen_id1.outputs.build-dir }} ${{runner.temp}}/ngen-build/
mv .github ${{runner.temp}}/.github
mv extern ${{runner.temp}}/extern
mv data ${{runner.temp}}/data

- name: Run surfacebmi plus cfebmi
- name: Move CFE Files Including cmake_build to Appropriate Directory
run: |
echo "end of ngen_integration testing"

# Checkout and build CFE
- name: Checkout the commit
uses: actions/checkout@v4
rm -rf extern/cfe/cfe/*
mv ${{runner.temp}}/cfe/* extern/cfe/cfe

- name: Build CFE Library for Ngen
- name: Run Ngen Test for CFE
run: |
cmake -B cmake_build -S . -DNGEN=ON
make -C cmake_build

# Move ngen build and other files to appropriate directory to run ngen
mv ${{runner.temp}}/ngen-build ./ngen-build
mv ${{runner.temp}}/extern/sloth extern
cp -r ${{runner.temp}}/extern/evapotranspiration extern
mv ${{runner.temp}}/data data

# Run ngen with CFE with PET
inputfile='realizations/realization_cfe_pet_ngenCI.json'
mv ${{ steps.ngen_id1.outputs.build-dir }} ./ngen-build/
inputfile='extern/cfe/cfe/realizations/realization_cfe_pet_ngenCI.json'
./ngen-build/ngen ./data/catchment_data.geojson "cat-27" ./data/nexus_data.geojson "nex-26" $inputfile

# The following remove a post ngen build error likely related to the temporary files left over during the
# build process
- name: Re-checkout Ngen
uses: actions/checkout@v3
with:
repository: noaa-owp/ngen
8 changes: 4 additions & 4 deletions realizations/realization_cfe_pet_ngenCI.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"model_type_name": "bmi_c_pet",
"library_file": "./extern/evapotranspiration/evapotranspiration/cmake_build/libpetbmi",
"forcing_file": "",
"init_config": "./configs/cat_87_bmi_config_pet_pass.txt",
"init_config": "./extern/cfe/cfe/configs/cat_87_bmi_config_pet_pass.txt",
"allow_exceed_end_time": true,
"main_output_variable": "water_potential_evaporation_flux",
"registration_function":"register_bmi_pet",
Expand All @@ -43,9 +43,9 @@
"name": "bmi_c",
"params": {
"model_type_name": "bmi_c_cfe",
"library_file": "./cmake_build/libcfebmi",
"library_file": "./extern/cfe/cfe/cmake_build/libcfebmi",
"forcing_file": "",
"init_config": "./configs/cat_87_bmi_config_cfe_pass.txt",
"init_config": "./extern/cfe/cfe/configs/cat_87_bmi_config_cfe_pass.txt",
"allow_exceed_end_time": true,
"main_output_variable": "Q_OUT",
"registration_function": "register_bmi_cfe",
Expand All @@ -72,7 +72,7 @@
}
],
"forcing": {
"path" : "./forcings/cat87_01Dec2015-.csv"
"path" : "./extern/cfe/cfe/forcings/cat87_01Dec2015-.csv"
}
},
"time": {
Expand Down
Loading