Bug Fix: Pandas loc-chaining #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHammond2
added
bug
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
+ Coverage 77.28% 77.29% +0.01%
===========================================
Files 29 29
Lines 3693 3695 +2
===========================================
+ Hits 2854 2856 +2
Misses 839 839 ☔ View full report in Codecov by Sentry. |
2 tasks
|
Thanks for fixing this @RHammond2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #270 by combining the chained
.locstatements into a single.locand addresses the missing NaN assignment inproject_ENGIE.py:clean_scada().An additional deprecation warning is also addressed by not concatenating empty data frames in the timeseries gap filling methods.