Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Upgrade Outdated Python Style #274

Merged

Conversation

RHammond2
Copy link
Collaborator

@RHammond2 RHammond2 commented Feb 6, 2024

This PR is the result of running pyupgrade --py38-plus against the codebase to identify lingering pre-3.8 language standards.

TODO prior to moving out of draft stage:

@RHammond2 RHammond2 changed the base branch from main to develop February 6, 2024 23:35
openoa/plant.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1d4074e) 72.50% compared to head (5338b44) 72.50%.

Files Patch % Lines
openoa/analysis/turbine_long_term_gross_energy.py 0.00% 0 Missing and 2 partials ⚠️
openoa/analysis/wake_losses.py 0.00% 1 Missing and 1 partial ⚠️
openoa/analysis/electrical_losses.py 0.00% 0 Missing and 1 partial ⚠️
openoa/analysis/yaw_misalignment.py 0.00% 0 Missing and 1 partial ⚠️
openoa/logging.py 0.00% 1 Missing ⚠️
openoa/utils/qa.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #274   +/-   ##
========================================
  Coverage    72.50%   72.50%           
========================================
  Files           29       29           
  Lines         3680     3680           
  Branches       794      794           
========================================
  Hits          2668     2668           
  Misses         823      823           
  Partials       189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RHammond2 RHammond2 marked this pull request as ready for review February 15, 2024 23:44
@RHammond2 RHammond2 merged commit c0485c8 into NREL:develop Feb 16, 2024
6 checks passed
@RHammond2 RHammond2 deleted the enhancement/upgrade-old-python-usage branch February 16, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants