Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Automation: Handle PRs opened as non-draft + multiple bug fixes #387

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Project Automation: Handle PRs opened as non-draft + multiple bug fixes #387

merged 7 commits into from
Sep 7, 2023
+24 −7

Conversation

jarmak-nv
Copy link
Collaborator

@jarmak-nv jarmak-nv commented Aug 30, 2023 •
edited
Loading

Description

closes #377
closes #408
closes #409

This PR Adds a step early in the workflow that:

  • If the event is a pull_request_target and the trigger is an opened trigger
    • If the PR is in draft, set a variable that is used later for Status mutations to In Progress
    • If it's not a draft, set that variable to In Review
  • Updates the mutations to use the new Status variable
  • Minor re-org of the initial env variables to have fields, then options grouped together

It also resolves the logic error found in #408 and the incorrect json reference in #409

Checklist

  • New or existing tests cover these changes. N/A
  • The documentation is up to date with these changes. N/A

@jarmak-nv jarmak-nv requested review from a team as code owners August 30, 2023 20:10
@jarmak-nv jarmak-nv requested review from jrhemstad and miscco and removed request for a team August 30, 2023 20:11
@jarmak-nv jarmak-nv self-assigned this Aug 30, 2023
jarmak-nv added a commit to jarmak-nv/cccl that referenced this pull request Sep 6, 2023
@jarmak-nv
[skip ci] Undoing fix for NVIDIA#408, moving it to NVIDIA#387
7ce9383
@jarmak-nv jarmak-nv marked this pull request as draft September 6, 2023 17:42
@jarmak-nv jarmak-nv changed the title Project Automation: Handle PRs opened as non-draft Project Automation: Handle PRs opened as non-draft + multiple bug fixes Sep 6, 2023
@jarmak-nv jarmak-nv marked this pull request as ready for review September 6, 2023 17:46
@jrhemstad jrhemstad merged commit ac161d7 into NVIDIA:main Sep 7, 2023
463 of 464 checks passed
jrhemstad pushed a commit that referenced this pull request Sep 7, 2023
@jarmak-nv
Project Automation: set Roadmap project value on issue/pr close and…
c7eb05d 
… Auto-type new issues (#389)

* Create action to set roadmap on close

* Update job name to be more descriptive

* [skip ci] fixing #408

* [skip ci] Undoing fix for #408, moving it to #387

* [skip ci] Add action to autoset issue type on open
@jarmak-nv jarmak-nv deleted the project-automation-updates branch November 28, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees

@jarmak-nv jarmak-nv

Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
2 participants
@jarmak-nv @jrhemstad