Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass custom passes from nvq++ #1034

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

1tnguyen
Copy link
Collaborator

Description

Ability to pass custom pass plugins (as .so files) from nvq++ to cudaq-opt and adding its passes to the pipeline.

Resolved #969

@1tnguyen 1tnguyen marked this pull request as ready for review December 13, 2023 00:02
tools/nvqpp/nvq++.in Outdated Show resolved Hide resolved
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
@1tnguyen 1tnguyen enabled auto-merge (squash) December 13, 2023 04:16
@1tnguyen 1tnguyen merged commit 2d60be7 into NVIDIA:main Dec 13, 2023
108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@amccaskey
Copy link
Collaborator

I know this has been merged, but one thing I'll add here is that we need to figure out how an external user can build custom pass plugins apart from CUDA Quantum (real plugins, without requiring a fork of the main repo). I think this is probably as straightforward as ensuring that our MLIR headers are installed (which they are not now).

@1tnguyen
Copy link
Collaborator Author

I know this has been merged, but one thing I'll add here is that we need to figure out how an external user can build custom pass plugins apart from CUDA Quantum (real plugins, without requiring a fork of the main repo). I think this is probably as straightforward as ensuring that our MLIR headers are installed (which they are not now).

Good point! I've posted #1037 to track this.

@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading MLIR plugins in NVQ++
5 participants