Convert the quake dialect ops to support both memory and register forms. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
force-pushed
the
ch-unified.ops
branch
from
488ad01
to
688edce
Compare
amccaskey
reviewed
May 1, 2023
amccaskey
reviewed
May 1, 2023
amccaskey
reviewed
May 1, 2023
schweitzpgi
force-pushed
the
ch-unified.ops
branch
4 times, most recently
from
712038b
to
f0b0420
Compare
amccaskey
reviewed
May 8, 2023
This unifies the quantum gate definitions into a single Op and eliminates the overhead of supporting parallel dialects for the same operations. See issue NVIDIA#98 for more. A large portion of these changes involves converting the tests to support a new syntax in which types are mandatory on quantum operations and more uniformly follow the MLIR default functional notation. Modify some specific points in the existing code to use the new op builder routines. Also begin the work of phasing out the Common directory, which will become obsolete after this refactoring is complete.
Drop the "q" prefix from the control type. In forthcoming work, the extra "q" prefixes on types in the dialect will be removed.
schweitzpgi
force-pushed
the
ch-unified.ops
branch
from
ec449d8
to
f94416b
Compare
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the quantum gate definitions into a single Op and eliminates the overhead of supporting parallel dialects for the same operations. See issue #98 for more.
A large portion of these changes involves converting the tests to support a new syntax in which types are mandatory on quantum operations and more uniformly follow the MLIR default functional notation.
Modify some specific points in the existing code to use the new op builder routines. Also begin the work of phasing out the Common directory, which will become obsolete after this refactoring is complete.