Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the quake dialect ops to support both memory and register forms. #124

Merged
merged 8 commits into from
May 8, 2023
Merged

Convert the quake dialect ops to support both memory and register forms. #124

merged 8 commits into from
May 8, 2023

Commits on May 8, 2023

  1. Convert the quake dialect ops to support both memory and register forms. 

    This unifies the quantum gate definitions into a single Op and
eliminates the overhead of supporting parallel dialects for the same
operations. See issue NVIDIA#98 for more.

A large portion of these changes involves converting the tests to
support a new syntax in which types are mandatory on quantum operations
and more uniformly follow the MLIR default functional notation.

Modify some specific points in the existing code to use the new op
builder routines. Also begin the work of phasing out the Common directory,
which will become obsolete after this refactoring is complete.
    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    fd9ac65 View commit details
    Browse the repository at this point in the history

  2. Update convert_ctrl documentation. 

    Drop the "q" prefix from the control type. In forthcoming work, the
extra "q" prefixes on types in the dialect will be removed.
    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    90342f5 View commit details
    Browse the repository at this point in the history

  3. Repair the python tests.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    80f3a7d View commit details
    Browse the repository at this point in the history

  4. More changes to check lines.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2a204e4 View commit details
    Browse the repository at this point in the history

  5. More check fixes.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    59a2f1e View commit details
    Browse the repository at this point in the history

  6. Fix bugs in decompositions now that result values are variadic.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f28b1da View commit details
    Browse the repository at this point in the history

  7. More check lines.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2a42ce4 View commit details
    Browse the repository at this point in the history

  8. Again.

    @schweitzpgi
    schweitzpgi committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f94416b View commit details
    Browse the repository at this point in the history